Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2835893004: [ios] Add support for filtering codesiging identity. (Closed)

Created:
3 years, 8 months ago by sdefresne
Modified:
3 years, 8 months ago
Reviewers:
justincohen
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Add support for filtering codesiging identity. Add a variable ios_code_signing_identity_description variable to control how the codesigning identity is selected (defaults to the old pattern "iPhone Developer"). This can be used to select a specific codesigning identity by name when a developer has multiple codesigning identities certificates installed on their machine (using a selection by name means there is nothing to change when the certificates are refreshed and the identifier is changed). BUG=714605 Review-Url: https://codereview.chromium.org/2835893004 Cr-Commit-Position: refs/heads/master@{#467002} Committed: https://chromium.googlesource.com/chromium/src/+/5ef9538469f035211a39b09d5f599d553acc23d3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M build/config/ios/find_signing_identity.py View 2 chunks +11 lines, -7 lines 0 comments Download
M build/config/ios/ios_sdk.gni View 3 chunks +33 lines, -9 lines 2 comments Download

Messages

Total messages: 14 (8 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 8 months ago (2017-04-24 14:00:47 UTC) #3
sdefresne
justincohen: ping
3 years, 8 months ago (2017-04-25 13:50:37 UTC) #7
justincohen
LGTM https://codereview.chromium.org/2835893004/diff/1/build/config/ios/ios_sdk.gni File build/config/ios/ios_sdk.gni (right): https://codereview.chromium.org/2835893004/diff/1/build/config/ios/ios_sdk.gni#newcode138 build/config/ios/ios_sdk.gni:138: print("TIP: Simulator builds don't require code signing...") I ...
3 years, 8 months ago (2017-04-25 14:31:38 UTC) #8
sdefresne
https://codereview.chromium.org/2835893004/diff/1/build/config/ios/ios_sdk.gni File build/config/ios/ios_sdk.gni (right): https://codereview.chromium.org/2835893004/diff/1/build/config/ios/ios_sdk.gni#newcode138 build/config/ios/ios_sdk.gni:138: print("TIP: Simulator builds don't require code signing...") On 2017/04/25 ...
3 years, 8 months ago (2017-04-25 14:34:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835893004/1
3 years, 8 months ago (2017-04-25 14:35:21 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 15:58:08 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ef9538469f035211a39b09d5f59...

Powered by Google App Engine
This is Rietveld 408576698