Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(60)

Issue 2835893002: Refactored out need to pass property to IsValidAnimationPropertyList. (Closed)

Created:
2 years, 6 months ago by Bugs Nash
Modified:
2 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored out need to pass property to IsValidAnimationPropertyList. Part of project Ribbon This refactor is one step in the process of refactoring out property specific logic inside switch cases in CSSPropertyParser::ParseSingleValue. This is required to implement the parseSingleValue methods in the property APIs without passing property ID to the API. Given that the IsValidAnimationPropertyList function only ever returned false if the property passed was CSSPropertyTransitionProperty, this check was moved to the calling methods. The next step in this process will be to refactor out the need to pass property to the ConsumeAnimationPropertyList function. At this stage the call to IsValidAnimationPropertyList will be moved to the CSSPropertyTransitionProperty case only and the check for this property will be removed. The check for this property in CSSPropertyParser::ConsumeAnimationShorthand will be refactored out at a later stage in project Ribbon. BUG=668012 Review-Url: https://codereview.chromium.org/2835893002 Cr-Commit-Position: refs/heads/master@{#467277} Committed: https://chromium.googlesource.com/chromium/src/+/b58fb7956f56025d0cf384376995ad54f39b6c78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bugs Nash
2 years, 6 months ago (2017-04-24 03:23:04 UTC) #4
nainar
lgtm
2 years, 6 months ago (2017-04-24 05:15:56 UTC) #7
Bugs Nash
+alancutter for owners
2 years, 6 months ago (2017-04-24 05:33:02 UTC) #9
alancutter (OOO until 2018)
lgtm
2 years, 6 months ago (2017-04-26 04:52:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835893002/1
2 years, 6 months ago (2017-04-26 07:12:27 UTC) #12
commit-bot: I haz the power
2 years, 6 months ago (2017-04-26 09:07:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b58fb7956f56025d0cf384376995...

Powered by Google App Engine
This is Rietveld 408576698