Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2835793002:
Print Preview: Assign to the header summary label only once. (Closed)
DescriptionPrint Preview: Assign to the header summary label only once.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2835793002
Cr-Commit-Position: refs/heads/master@{#466816}
Committed: https://chromium.googlesource.com/chromium/src/+/5c1cec458f824baa15f38873d845aca2e8515bf5
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit #Messages
Total messages: 26 (19 generated)
Description was changed from ========== Print Preview: Assign to the header summary label only once. ========== to ========== Print Preview: Assign to the header summary label only once. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Print Preview: Assign to the header summary label only once. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Print Preview: Assign to the header summary label only once. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
thestig@chromium.org changed reviewers: + dpapad@chromium.org, rbpotter@chromium.org
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/22 01:57:50, Lei Zhang wrote: lgtm
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM https://codereview.chromium.org/2835793002/diff/1/chrome/browser/resources/pr... File chrome/browser/resources/print_preview/print_header.js (right): https://codereview.chromium.org/2835793002/diff/1/chrome/browser/resources/pr... chrome/browser/resources/print_preview/print_header.js:184: summaryLabel = saveToPdfOrDrive ? Nit: Can be compacted even further as follows: summaryLabel = loadTimeData.getString( saveToPdfOrDrive ? printPreviewPageLabelSingular : printPreviewSheetsLabelSingular);
The CQ bit was unchecked by thestig@chromium.org
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2835793002/diff/1/chrome/browser/resources/pr... File chrome/browser/resources/print_preview/print_header.js (right): https://codereview.chromium.org/2835793002/diff/1/chrome/browser/resources/pr... chrome/browser/resources/print_preview/print_header.js:184: summaryLabel = saveToPdfOrDrive ? On 2017/04/24 17:23:40, dpapad wrote: > Nit: Can be compacted even further as follows: > > summaryLabel = loadTimeData.getString( > saveToPdfOrDrive ? > printPreviewPageLabelSingular : printPreviewSheetsLabelSingular); Done.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org, rbpotter@chromium.org Link to the patchset: https://codereview.chromium.org/2835793002/#ps20001 (title: "nit")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493075553281450,
"parent_rev": "7ac2374e5a71a1c49f8cf433726ce6f4afb81c4e", "commit_rev":
"5c1cec458f824baa15f38873d845aca2e8515bf5"}
Message was sent while issue was closed.
Description was changed from ========== Print Preview: Assign to the header summary label only once. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Print Preview: Assign to the header summary label only once. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2835793002 Cr-Commit-Position: refs/heads/master@{#466816} Committed: https://chromium.googlesource.com/chromium/src/+/5c1cec458f824baa15f38873d845... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5c1cec458f824baa15f38873d845... |
