Issue 2835743002: add an option to turn off errors from strong mode is-checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2835743002: add an option to turn off errors from strong mode is-checks (Closed)

Created:
3 years, 8 months ago by Jennifer Messerly

Modified:
3 years, 8 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

add an option to turn off errors from strong mode is-checks This adds an option and also has our tests run with it turned off. R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/bed6f8242a786f2b7bcaca68a0d394063dae859a

Created: 3 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -35 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	1	Binary file		0 comments	Download
M	pkg/dev_compiler/test/browser/language_tests.js	View	1	5 chunks	+2 lines, -35 lines	0 comments	Download
M	pkg/dev_compiler/test/browser/runtime_tests.js	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

3 years, 8 months ago (2017-04-21 22:24:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:10001) manually as
bed6f8242a786f2b7bcaca68a0d394063dae859a (presubmit successful).