pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 2835743002: add an option to turn off errors from strong mode is-checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2835743002: add an option to turn off errors from strong mode is-checks (Closed)

Patch Set: fix comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index 9591d8927ee570ef9547b48caa36f58ccaf4306c..a34f49d47acf5118cc62a127abb0a2bd0f8cb66f 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -480,6 +480,7 @@ instanceOf(obj, type) => JS(

}

let result = $strongInstanceOf($obj, $type);

if (result !== null) return result;

+ if (!$_failForWeakModeIsChecks) return false;

let actual = $getReifiedType($obj);

$throwStrongModeError('Strong mode is-check failure: ' +

$typeName(actual) + ' does not soundly subtype ' +

« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart ('k') | no next file » | no next file with comments »