Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2835693002:
Mark a WebGL2 test Flaky (Closed)
|
Created:
3 years, 8 months ago by ynovikov Modified:
3 years, 8 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMark a WebGL2 test Flaky
deqp/functional/gles3/multisample.html
on linux nvidia
Used to be Fail on Linux NVIDIA Quadro P400,
tentatively marking as Flaky there as well.
BUG=714207, 702861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2835693002
Cr-Commit-Position: refs/heads/master@{#466438}
Committed: https://chromium.googlesource.com/chromium/src/+/74486301cfa4958e9627a17d053ecf2886f74d50
Patch Set 1 #Patch Set 2 : fix conflict #Messages
Total messages: 18 (9 generated)
Description was changed from ========== Mark a WebGL2 test Flaky deqp/functional/gles3/multisample.html on linux nvidia BUG=714207 TBR=kbr@chromium.org ========== to ========== Mark a WebGL2 test Flaky deqp/functional/gles3/multisample.html on linux nvidia BUG=714207 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by ynovikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm, but the presubmit failure indicates that it should have complained during the CL upload.
The CQ bit was checked by ynovikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/21 19:31:02, Ken Russell wrote: > lgtm, but the presubmit failure indicates that it should have complained during > the CL upload. It did complain, I just didn't notice. Presubmit always complains for me for these expectations for other reasons. I think maybe because I have clank checkout and not chromium.
On 2017/04/21 19:35:09, ynovikov wrote: > On 2017/04/21 19:31:02, Ken Russell wrote: > > lgtm, but the presubmit failure indicates that it should have complained > during > > the CL upload. > > It did complain, I just didn't notice. > Presubmit always complains for me for these expectations for other reasons. I > think maybe because I have clank checkout and not chromium. If src/third_party/webgl is updated properly via gclient sync, you shouldn't get warnings except when rolling the WebGL conformance suite.
Description was changed from ========== Mark a WebGL2 test Flaky deqp/functional/gles3/multisample.html on linux nvidia BUG=714207 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Mark a WebGL2 test Flaky deqp/functional/gles3/multisample.html on linux nvidia Used to be Fail on Linux NVIDIA Quadro P400, tentatively marking as Flaky there as well. BUG=714207,702861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/04/21 19:36:03, Ken Russell wrote:
> On 2017/04/21 19:35:09, ynovikov wrote:
> > On 2017/04/21 19:31:02, Ken Russell wrote:
> > > lgtm, but the presubmit failure indicates that it should have complained
> > during
> > > the CL upload.
> >
> > It did complain, I just didn't notice.
> > Presubmit always complains for me for these expectations for other reasons.
I
> > think maybe because I have clank checkout and not chromium.
>
> If src/third_party/webgl is updated properly via gclient sync, you shouldn't
get
> warnings except when rolling the WebGL conformance suite.
I do sync.
I always get this:
[30/33] gpu_tests.lint_unittest.LintTest.testPassingPylintCheckForGpuTestsDir
failed unexpectedly 0.0277s:
Traceback (most recent call last):
File
"/usr/local/google/work/clank/src/content/test/gpu/gpu_tests/lint_unittest.py",
line 42, in testPassingPylintCheckForGpuTestsDir
self.assertTrue(LintCheckPassed(os.path.abspath(os.path.dirname(__file__))))
File
"/usr/local/google/work/clank/src/content/test/gpu/gpu_tests/lint_unittest.py",
line 31, in LintCheckPassed
lint.Run(args)
File "/usr/lib/python2.7/dist-packages/pylint/lint.py", line 1012, in
__init__
linter.load_config_file()
File
"/usr/local/google/work/clank/src/third_party/logilab/logilab/common/configuration.py",
line 672, in load_config_file
self.global_set_option(option, value)
File
"/usr/local/google/work/clank/src/third_party/logilab/logilab/common/configuration.py",
line 555, in global_set_option
self._all_options[opt].set_option(opt, value)
File "/usr/lib/python2.7/dist-packages/pylint/lint.py", line 392, in
set_option
meth(_id)
File "/usr/lib/python2.7/dist-packages/pylint/utils.py", line 276, in
disable
msg = self.check_message_id(msgid)
File "/usr/lib/python2.7/dist-packages/pylint/utils.py", line 341, in
check_message_id
raise UnknownMessage('No such message id %s' % msgid)
UnknownMessage: No such message id bad-continuation
The CQ bit was unchecked by ynovikov@chromium.org
The CQ bit was checked by ynovikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492803596641000,
"parent_rev": "5e09768cc0dbe423fb0a5365489b8751730671a7", "commit_rev":
"74486301cfa4958e9627a17d053ecf2886f74d50"}
Message was sent while issue was closed.
Description was changed from ========== Mark a WebGL2 test Flaky deqp/functional/gles3/multisample.html on linux nvidia Used to be Fail on Linux NVIDIA Quadro P400, tentatively marking as Flaky there as well. BUG=714207,702861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Mark a WebGL2 test Flaky deqp/functional/gles3/multisample.html on linux nvidia Used to be Fail on Linux NVIDIA Quadro P400, tentatively marking as Flaky there as well. BUG=714207,702861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2835693002 Cr-Commit-Position: refs/heads/master@{#466438} Committed: https://chromium.googlesource.com/chromium/src/+/74486301cfa4958e9627a17d053e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/74486301cfa4958e9627a17d053e... |
