Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2835643002: [ObjC ARC] Converts ios/chrome/browser/ui/downloads:downloads to ARC. (Closed)

Created:
7 months ago by gambard
Modified:
6 months, 3 weeks ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/downloads:downloads to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2835643002 Cr-Commit-Position: refs/heads/master@{#467682} Committed: https://chromium.googlesource.com/chromium/src/+/d7397a48a29569458940d1b5f8b44fbf776b4efa

Patch Set 1 #

Patch Set 2 : Fix weaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -52 lines) Patch
M ios/chrome/browser/ui/downloads/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/downloads/download_manager_controller.mm View 1 18 chunks +50 lines, -52 lines 0 comments Download
Trybot results:  win_chromium_x64_rel_ng   win_clang   win_chromium_compile_dbg_ng   win_chromium_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_arm64_dbg_recipe   android_clang_dbg_recipe   android_n5x_swarming_rel   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   ios-device   linux_chromium_chromeos_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   cast_shell_android   linux_android_rel_ng   android_n5x_swarming_rel   android_compile_dbg   android_clang_dbg_recipe   android_cronet   android_arm64_dbg_recipe 

Messages

Total messages: 14 (10 generated)
gambard
PTAL.
7 months ago (2017-04-21 09:39:16 UTC) #4
sdefresne
lgtm
6 months, 3 weeks ago (2017-04-27 13:39:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835643002/20001
6 months, 3 weeks ago (2017-04-27 13:50:14 UTC) #11
commit-bot: I haz the power
6 months, 3 weeks ago (2017-04-27 15:17:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d7397a48a29569458940d1b5f8b4...

Powered by Google App Engine
This is Rietveld efc10ee0f