third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp - Issue 2835633002: Add more checks to diagnose MediaQuerySet issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp

Issue 2835633002: Add more checks to diagnose MediaQuerySet issue (Closed)

Patch Set: fix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp

diff --git a/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp b/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp

index bb422e0ca97c250efaa68788420776827ce1b193..5b4c05688fd675fe6c4719694c6bf4029c5d5005 100644

--- a/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp

+++ b/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp

@@ -50,7 +50,11 @@ void DocumentStyleSheetCollection::CollectStyleSheetsFromCandidates(

DocumentStyleSheetCollector& collector) {

DocumentOrderedList::MutationForbiddenScope mutation_forbidden_(

&style_sheet_candidate_nodes_);

+ CHECK(HeapObjectHeader::FromPayload(this)->IsValid());

haraken 2017/04/21 10:51:54 Add a TODO to remove the checks once the investiga

+ CHECK(ThreadState::Current()->IsOnThreadHeap(this));

for (Node* n : style_sheet_candidate_nodes_) {

+ CHECK(HeapObjectHeader::FromPayload(n)->IsValid());

+ CHECK(ThreadState::Current()->IsOnThreadHeap(n));

StyleSheetCandidate candidate(*n);

DCHECK(!candidate.IsXSL());

« no previous file with comments | « third_party/WebKit/Source/core/css/MediaList.cpp ('k') | third_party/WebKit/Source/platform/heap/HeapPage.h » ('j') | no next file with comments »