components/password_manager/core/browser/password_syncable_service.cc - Issue 283563002: Password Login Database: report correct changes from AddLogin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service.cc

Issue 283563002: Password Login Database: report correct changes from AddLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed PasswordSyncableServiceTest.PasswordStoreChanges Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/login_database_unittest.cc ('K') | « components/password_manager/core/browser/password_store_default.cc ('k') | components/password_manager/core/browser/password_syncable_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service.cc

diff --git a/components/password_manager/core/browser/password_syncable_service.cc b/components/password_manager/core/browser/password_syncable_service.cc

index ae886fa46ace878a23e5373faf7376ee2aef6f9d..61d1d40a64f1fb569d662d4bc5ea139233143a1e 100644

--- a/components/password_manager/core/browser/password_syncable_service.cc

+++ b/components/password_manager/core/browser/password_syncable_service.cc

@@ -275,10 +275,12 @@ void PasswordSyncableService::ActOnPasswordStoreChanges(

for (PasswordStoreChangeList::const_iterator it = local_changes.begin();

it != local_changes.end();

++it) {

+ syncer::SyncData data = (it->type() == PasswordStoreChange::REMOVE ?

+ syncer::SyncData::CreateLocalDelete(MakePasswordSyncTag(it->form()),

+ syncer::PASSWORDS) :

+ SyncDataFromPassword(it->form()));

sync_changes.push_back(

- syncer::SyncChange(FROM_HERE,

- GetSyncChangeType(it->type()),

- SyncDataFromPassword(it->form())));

+ syncer::SyncChange(FROM_HERE, GetSyncChangeType(it->type()), data));

}

sync_processor_->ProcessSyncChanges(FROM_HERE, sync_changes);

}