components/password_manager/core/browser/password_store_default.cc - Issue 283563002: Password Login Database: report correct changes from AddLogin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 283563002: Password Login Database: report correct changes from AddLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed PasswordSyncableServiceTest.PasswordStoreChanges Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_store_default.cc

diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc

index 8997c6f0864cb93362cf58d12b47b99f49284f8e..f2eb7d7b09b7eb59433c1ccaec7b7fe28a8d24c5 100644

--- a/components/password_manager/core/browser/password_store_default.cc

+++ b/components/password_manager/core/browser/password_store_default.cc

@@ -35,9 +35,7 @@ PasswordStoreChangeList PasswordStoreDefault::AddLoginImpl(

const PasswordForm& form) {

DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());

PasswordStoreChangeList changes;

- if (login_db_->AddLogin(form))

- changes.push_back(PasswordStoreChange(PasswordStoreChange::ADD, form));

- return changes;

+ return login_db_->AddLogin(form);

}

PasswordStoreChangeList PasswordStoreDefault::UpdateLoginImpl(