chrome/browser/password_manager/password_store_x.h - Issue 283563002: Password Login Database: report correct changes from AddLogin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 283563002: Password Login Database: report correct changes from AddLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: the nit addressed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_store_x.h

diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h

index 0eb2bea0a72f1239018a88af6b843966bfb4fbab..ac1cf52b2ec4ba2a670bec74f1648a8bb5dc80fc 100644

--- a/chrome/browser/password_manager/password_store_x.h

+++ b/chrome/browser/password_manager/password_store_x.h

@@ -40,7 +40,8 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {

virtual bool Init() = 0;

- virtual bool AddLogin(const autofill::PasswordForm& form) = 0;

+ virtual password_manager::PasswordStoreChangeList AddLogin(

+ const autofill::PasswordForm& form) = 0;

virtual bool UpdateLogin(const autofill::PasswordForm& form) = 0;

virtual bool RemoveLogin(const autofill::PasswordForm& form) = 0;

virtual bool RemoveLoginsCreatedBetween(const base::Time& delete_begin,