Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/browser/password_manager/password_store_x.h

Issue 283563002: Password Login Database: report correct changes from AddLogin(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: the nit addressed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 22 matching lines...) Expand all
33 // NativeBackends more or less implement the PaswordStore interface, but 33 // NativeBackends more or less implement the PaswordStore interface, but
34 // with return values rather than implicit consumer notification. 34 // with return values rather than implicit consumer notification.
35 class NativeBackend { 35 class NativeBackend {
36 public: 36 public:
37 typedef std::vector<autofill::PasswordForm*> PasswordFormList; 37 typedef std::vector<autofill::PasswordForm*> PasswordFormList;
38 38
39 virtual ~NativeBackend() {} 39 virtual ~NativeBackend() {}
40 40
41 virtual bool Init() = 0; 41 virtual bool Init() = 0;
42 42
43 virtual bool AddLogin(const autofill::PasswordForm& form) = 0; 43 virtual password_manager::PasswordStoreChangeList AddLogin(
44 const autofill::PasswordForm& form) = 0;
44 virtual bool UpdateLogin(const autofill::PasswordForm& form) = 0; 45 virtual bool UpdateLogin(const autofill::PasswordForm& form) = 0;
45 virtual bool RemoveLogin(const autofill::PasswordForm& form) = 0; 46 virtual bool RemoveLogin(const autofill::PasswordForm& form) = 0;
46 virtual bool RemoveLoginsCreatedBetween(const base::Time& delete_begin, 47 virtual bool RemoveLoginsCreatedBetween(const base::Time& delete_begin,
47 const base::Time& delete_end) = 0; 48 const base::Time& delete_end) = 0;
48 virtual bool GetLogins(const autofill::PasswordForm& form, 49 virtual bool GetLogins(const autofill::PasswordForm& form,
49 PasswordFormList* forms) = 0; 50 PasswordFormList* forms) = 0;
50 virtual bool GetLoginsCreatedBetween(const base::Time& get_begin, 51 virtual bool GetLoginsCreatedBetween(const base::Time& get_begin,
51 const base::Time& get_end, 52 const base::Time& get_end,
52 PasswordFormList* forms) = 0; 53 PasswordFormList* forms) = 0;
53 virtual bool GetAutofillableLogins(PasswordFormList* forms) = 0; 54 virtual bool GetAutofillableLogins(PasswordFormList* forms) = 0;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // Whether we should allow falling back to the default store. If there is 114 // Whether we should allow falling back to the default store. If there is
114 // nothing to migrate, then the first attempt to use the native store will 115 // nothing to migrate, then the first attempt to use the native store will
115 // be the first time we try to use it and we should allow falling back. If 116 // be the first time we try to use it and we should allow falling back. If
116 // we have migrated successfully, then we do not allow falling back. 117 // we have migrated successfully, then we do not allow falling back.
117 bool allow_fallback_; 118 bool allow_fallback_;
118 119
119 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX); 120 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX);
120 }; 121 };
121 122
122 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 123 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.cc ('k') | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698