Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2835613002: Remove redundant "type=str" in Mojo bindings generator. (Closed)

Created:
3 years, 8 months ago by nigeltao1
Modified:
3 years, 8 months ago
Reviewers:
yzshen1, M-A Ruel
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant "type=str" in Mojo bindings generator. https://docs.python.org/3/library/argparse.html#type says that the default type is already string. BUG= Review-Url: https://codereview.chromium.org/2835613002 Cr-Commit-Position: refs/heads/master@{#466264} Committed: https://chromium.googlesource.com/chromium/src/+/5993a053576133ba8fe2405bc33c7cc85f164288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nigeltao1
3 years, 8 months ago (2017-04-20 23:55:27 UTC) #2
M-A Ruel
lgtm
3 years, 8 months ago (2017-04-20 23:56:31 UTC) #3
nigeltao1
yzshen, can you review for OWNERS?
3 years, 8 months ago (2017-04-20 23:57:37 UTC) #5
yzshen1
lgtm
3 years, 8 months ago (2017-04-21 00:44:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835613002/1
3 years, 8 months ago (2017-04-21 03:49:01 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 05:04:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5993a053576133ba8fe2405bc33c...

Powered by Google App Engine
This is Rietveld 408576698