Revert of [autoroller] All commits in updates(), only roll interesting ones.

Revert of [autoroller] All commits in updates(), only roll interesting ones. (patchset #3 id:40001 of https://codereview.chromium.org/2833723003/ )

Reason for revert:
'^!' apparently gets some crappy escape magic on windows: https://luci-milo.appspot.com/swarming/task/35a662db00607910

Original issue's description:
> [autoroller] All commits in updates(), only roll interesting ones.
> 
> Previously `updates` would only include the 'interesting' updates, which
> meant that the new autoroller algorithm skips over chunks of the repo
> history. If multiple repos have chunks of non-interesting history, the
> autoroller can end up not proposing any good candidates.
> 
> This CL simplifies the repo interface by having `updates()` always
> return the full list of commits, but adds a new field to the
> CommitMetadata which indicates that a given commit was `interesting`.
> This way the full history of every repo is available when picking
> candidates (e.g. for `CommitList.advance_to`), but find_best_rev will
> only consider rolling to interesting commits.
> 
> R=dnj@chromium.org, phajdan.jr@chromium.org
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2833723003
> Committed: https://github.com/luci/recipes-py/commit/30925bd08c1f78e835f04a2a3d409cf027cde55e

TBR=dnj@chromium.org,phajdan.jr@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2835593002
Committed: https://github.com/luci/recipes-py/commit/84d216aab872ff9d2ea18a39620fec428ea38e57

[iannucci1, 2017-04-20 23:03:56]

The CQ bit was checked by iannucci@google.com

[iannucci1, 2017-04-20 23:03:57]

Created Revert of [autoroller] All commits in updates(), only roll interesting
ones.

[commit-bot: I haz the power, 2017-04-20 23:04:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 23:04:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492729436785560, "parent_rev":
"30925bd08c1f78e835f04a2a3d409cf027cde55e", "commit_rev":
"84d216aab872ff9d2ea18a39620fec428ea38e57"}

[commit-bot: I haz the power, 2017-04-20 23:04:19]

Description was changed from

==========
Revert of [autoroller] All commits in updates(), only roll interesting ones.
(patchset #3 id:40001 of https://codereview.chromium.org/2833723003/ )

Reason for revert:
'^!' apparently gets some crappy escape magic on windows:
https://luci-milo.appspot.com/swarming/task/35a662db00607910

Original issue's description:
> [autoroller] All commits in updates(), only roll interesting ones.
> 
> Previously `updates` would only include the 'interesting' updates, which
> meant that the new autoroller algorithm skips over chunks of the repo
> history. If multiple repos have chunks of non-interesting history, the
> autoroller can end up not proposing any good candidates.
> 
> This CL simplifies the repo interface by having `updates()` always
> return the full list of commits, but adds a new field to the
> CommitMetadata which indicates that a given commit was `interesting`.
> This way the full history of every repo is available when picking
> candidates (e.g. for `CommitList.advance_to`), but find_best_rev will
> only consider rolling to interesting commits.
> 
> R=dnj@chromium.org, phajdan.jr@chromium.org
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2833723003
> Committed:
https://github.com/luci/recipes-py/commit/30925bd08c1f78e835f04a2a3d409cf027c...

TBR=dnj@chromium.org,phajdan.jr@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of [autoroller] All commits in updates(), only roll interesting ones.
(patchset #3 id:40001 of https://codereview.chromium.org/2833723003/ )

Reason for revert:
'^!' apparently gets some crappy escape magic on windows:
https://luci-milo.appspot.com/swarming/task/35a662db00607910

Original issue's description:
> [autoroller] All commits in updates(), only roll interesting ones.
> 
> Previously `updates` would only include the 'interesting' updates, which
> meant that the new autoroller algorithm skips over chunks of the repo
> history. If multiple repos have chunks of non-interesting history, the
> autoroller can end up not proposing any good candidates.
> 
> This CL simplifies the repo interface by having `updates()` always
> return the full list of commits, but adds a new field to the
> CommitMetadata which indicates that a given commit was `interesting`.
> This way the full history of every repo is available when picking
> candidates (e.g. for `CommitList.advance_to`), but find_best_rev will
> only consider rolling to interesting commits.
> 
> R=dnj@chromium.org, phajdan.jr@chromium.org
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2833723003
> Committed:
https://github.com/luci/recipes-py/commit/30925bd08c1f78e835f04a2a3d409cf027c...

TBR=dnj@chromium.org,phajdan.jr@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2835593002
Committed:
https://github.com/luci/recipes-py/commit/84d216aab872ff9d2ea18a39620fec428ea...
==========

[commit-bot: I haz the power, 2017-04-20 23:04:19]

Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/84d216aab872ff9d2ea18a39620fec428ea...