Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2835573002: [Extensions Bindings] Add support for maximum integers (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
lazyboy, jbroman
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Add support for maximum integers chrome.gcm uses a "maximum" field. Add support for it in ArgumentSpec, and update unittests. BUG=653596 Review-Url: https://codereview.chromium.org/2835573002 Cr-Commit-Position: refs/heads/master@{#466378} Committed: https://chromium.googlesource.com/chromium/src/+/c06b81979bdaed0243c100833f011e6bd664fe9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M extensions/renderer/argument_spec.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/argument_spec.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M extensions/renderer/argument_spec_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Devlin
Another one for y'all.
3 years, 8 months ago (2017-04-21 00:44:14 UTC) #6
lazyboy
lgtm
3 years, 8 months ago (2017-04-21 01:07:44 UTC) #7
jbroman
lgtm
3 years, 8 months ago (2017-04-21 15:36:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835573002/1
3 years, 8 months ago (2017-04-21 16:37:45 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 17:28:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c06b81979bdaed0243c100833f01...

Powered by Google App Engine
This is Rietveld 408576698