Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2835563004:
Disable flaky testBrowsingPostToSamePage on devices. (Closed)
|
Created:
3 years, 8 months ago by liaoyuke Modified:
3 years, 8 months ago Reviewers:
Eugene But (OOO till 7-30) CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable flaky testBrowsingPostToSamePage on devices.
testBrowsingPostToSamePage is flaky on devices. For example:
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/
iphone10-device-x64/builds/4627
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/
iphone10-device-x64/builds/4622
TBR=eugenebut@chromium.org
BUG=714303
Review-Url: https://codereview.chromium.org/2835563004
Cr-Commit-Position: refs/heads/master@{#466491}
Committed: https://chromium.googlesource.com/chromium/src/+/5cd3126fe5f3a66e8e2fd0f134e3ec3caaab9f87
Patch Set 1 #
Total comments: 1
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=714303 ========== to ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=714303 ==========
liaoyuke@chromium.org changed reviewers: + eugenebut@chromium.org
Description was changed from ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=714303 ========== to ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=714303 ==========
liaoyuke@chromium.org changed reviewers: + eugenebut@chromium.org
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 BUG=714303 ========== to ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 TBR=eugenebut@chromium.org BUG=714303 ==========
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by eugenebut@chromium.org
https://codereview.chromium.org/2835563004/diff/1/ios/chrome/browser/web/brow... File ios/chrome/browser/web/browsing_egtest.mm (right): https://codereview.chromium.org/2835563004/diff/1/ios/chrome/browser/web/brow... ios/chrome/browser/web/browsing_egtest.mm:445: #if !TARGET_IPHONE_SIMULATOR We normally use MAYBE_ macro for disabling tests on device.
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492817213306650, "parent_rev":
"d5a456422acfcbcfd11be8d01cd3defdcdea9f7f", "commit_rev":
"5cd3126fe5f3a66e8e2fd0f134e3ec3caaab9f87"}
Message was sent while issue was closed.
Description was changed from ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 TBR=eugenebut@chromium.org BUG=714303 ========== to ========== Disable flaky testBrowsingPostToSamePage on devices. testBrowsingPostToSamePage is flaky on devices. For example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4627 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ iphone10-device-x64/builds/4622 TBR=eugenebut@chromium.org BUG=714303 Review-Url: https://codereview.chromium.org/2835563004 Cr-Commit-Position: refs/heads/master@{#466491} Committed: https://chromium.googlesource.com/chromium/src/+/5cd3126fe5f3a66e8e2fd0f134e3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5cd3126fe5f3a66e8e2fd0f134e3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
