Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2835503003: Replace SyncTest::SetUpInProcessBrowserTestFixture with SyncTest::SetUpOnMainThread. (Closed)

Created:
3 years, 8 months ago by jam
Modified:
3 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SyncTest::SetUpInProcessBrowserTestFixture with SyncTest::SetUpOnMainThread. The former was added a long time ago in https://codereview.chromium.org/214047 before we had SetUpOnMainThread. We don't need SetUpInProcessBrowserTestFixture anymore after the core browser test harness has been split apart. Since SetUpInProcessBrowserTestFixture was added for sync, removing it here first and then I'll remove the other usages later. BUG=713847 Review-Url: https://codereview.chromium.org/2835503003 Cr-Commit-Position: refs/heads/master@{#466151} Committed: https://chromium.googlesource.com/chromium/src/+/4621c2490b9b9cc5cba1d57a57c6009687190eef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -34 lines) Patch
M chrome/browser/sync/test/integration/sync_test.h View 4 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 8 months ago (2017-04-20 20:02:09 UTC) #5
Nicolas Zea
lgtm
3 years, 8 months ago (2017-04-20 21:18:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835503003/1
3 years, 8 months ago (2017-04-20 21:48:26 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 21:52:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4621c2490b9b9cc5cba1d57a57c6...

Powered by Google App Engine
This is Rietveld 408576698