Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2835483002: Add use counter for dispatching mouse events on disabled form controls. (Closed)

Created:
3 years, 8 months ago by dtapuska
Modified:
3 years, 8 months ago
Reviewers:
haraken, bokan, Mike West
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counter for dispatching mouse events on disabled form controls. We need to determine if this code actually executes in the wild. I doubt it really does with any high occurrence. Edge, FireFox behave differently. BUG=713711 Review-Url: https://codereview.chromium.org/2835483002 Cr-Commit-Position: refs/heads/master@{#466337} Committed: https://chromium.googlesource.com/chromium/src/+/c81c13ac449b26b113f79c4b1155f21976724bd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
dtapuska
3 years, 8 months ago (2017-04-20 16:23:00 UTC) #3
bokan
lgtm Is the intent to match the other browsers? Is there any agreement on behavior?
3 years, 8 months ago (2017-04-20 20:30:08 UTC) #4
dtapuska
On 2017/04/20 20:30:08, bokan wrote: > lgtm > > Is the intent to match the ...
3 years, 8 months ago (2017-04-20 20:32:39 UTC) #5
dtapuska
mkwst@chromium.org: Please review changes in histograms.xml
3 years, 8 months ago (2017-04-20 20:34:22 UTC) #7
haraken
On 2017/04/20 20:34:22, dtapuska wrote: > mailto:mkwst@chromium.org: Please review changes in > > histograms.xml LGTM
3 years, 8 months ago (2017-04-20 20:34:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835483002/1
3 years, 8 months ago (2017-04-20 20:37:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/435441)
3 years, 8 months ago (2017-04-20 22:21:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835483002/1
3 years, 8 months ago (2017-04-21 13:54:05 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 15:04:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c81c13ac449b26b113f79c4b1155...

Powered by Google App Engine
This is Rietveld 408576698