Make the ThrottledOfflineContentProvider better

Make the ThrottledOfflineContentProvider better

Simple improvements to make the throttle work in a more expected way.
- Calling any method to update the underlying contents of the throttle
will allow the all queued updates to flush.
- Calling updates infrequently will not queue.  Instead we track the
time since the last update and don't queue if the time has been long
enough.
- Hook the throttle into the JNI bridge for the Android
OfflineContentProvider.

BUG=715669
Review-Url: https://codereview.chromium.org/2835323005
Cr-Commit-Position: refs/heads/master@{#467930}
Committed: https://chromium.googlesource.com/chromium/src/+/a7273fae139189164a0a6733cd717e570ebe343e

[David Trainor- moved to gerrit, 2017-04-26 18:04:20]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 18:05:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-04-26 18:51:22]

dtrainor@chromium.org changed reviewers:
+ fgorski@chromium.org, qinmin@chromium.org

[David Trainor- moved to gerrit, 2017-04-26 18:51:22]

ptal thanks!

[commit-bot: I haz the power, 2017-04-26 19:11:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 19:11:35]

Dry run: This issue passed the CQ dry run.

[qinmin, 2017-04-27 17:18:44]

lgtm % comments

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
File
components/offline_items_collection/core/throttled_offline_content_provider.h
(right):

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
components/offline_items_collection/core/throttled_offline_content_provider.h:37:
// immediately after performing the action.  This is to make sure item updates
nit: extra white space before "This"

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
components/offline_items_collection/core/throttled_offline_content_provider.h:55:
// Visible for testing.  Overrides the time at which this throttle last pushed
Ditto

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
components/offline_items_collection/core/throttled_offline_content_provider.h:80:
base::Time last_update_time_;
sure not to use TimeTicks?

[David Trainor- moved to gerrit, 2017-04-28 01:09:05]

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
File
components/offline_items_collection/core/throttled_offline_content_provider.h
(right):

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
components/offline_items_collection/core/throttled_offline_content_provider.h:37:
// immediately after performing the action.  This is to make sure item updates
On 2017/04/27 17:18:44, qinmin wrote:
> nit: extra white space before "This"

Ah I always do two after a period.  Habit :(.  I can remove.

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
components/offline_items_collection/core/throttled_offline_content_provider.h:55:
// Visible for testing.  Overrides the time at which this throttle last pushed
On 2017/04/27 17:18:44, qinmin wrote:
> Ditto

Done.

https://codereview.chromium.org/2835323005/diff/1/components/offline_items_co...
components/offline_items_collection/core/throttled_offline_content_provider.h:80:
base::Time last_update_time_;
On 2017/04/27 17:18:44, qinmin wrote:
> sure not to use TimeTicks?

Ah better thanks!

[David Trainor- moved to gerrit, 2017-04-28 07:26:51]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-04-28 07:26:51]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2835323005/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-28 07:27:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 08:27:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493364411354180,
"parent_rev": "82ecc71c03b9c7a0478849b3df403c1518b05642", "commit_rev":
"a7273fae139189164a0a6733cd717e570ebe343e"}

[commit-bot: I haz the power, 2017-04-28 08:27:31]

Description was changed from

==========
Make the ThrottledOfflineContentProvider better

Simple improvements to make the throttle work in a more expected way.
- Calling any method to update the underlying contents of the throttle
will allow the all queued updates to flush.
- Calling updates infrequently will not queue.  Instead we track the
time since the last update and don't queue if the time has been long
enough.
- Hook the throttle into the JNI bridge for the Android
OfflineContentProvider.

BUG=715669
==========

to

==========
Make the ThrottledOfflineContentProvider better

Simple improvements to make the throttle work in a more expected way.
- Calling any method to update the underlying contents of the throttle
will allow the all queued updates to flush.
- Calling updates infrequently will not queue.  Instead we track the
time since the last update and don't queue if the time has been long
enough.
- Hook the throttle into the JNI bridge for the Android
OfflineContentProvider.

BUG=715669

Review-Url: https://codereview.chromium.org/2835323005
Cr-Commit-Position: refs/heads/master@{#467930}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7273fae139189164a0a6733cd71...
==========

[commit-bot: I haz the power, 2017-04-28 08:27:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a7273fae139189164a0a6733cd71...