Handle @NoInline annotations in closed_world2_test

Handle @NoInline annotations in closed_world2_test

+ make closed_world_tester a bit more flexible.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9b6eb81b012addd05d73f9fb15ce08f06e5ab9df

[Johnni Winther, 2017-04-26 14:45:28]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-04-26 16:46:59]

lgtm

[Siggi Cherem (dart-lang), 2017-04-26 17:24:07]

before i forget, every time I see this class it makes me think of the comments
below...

https://codereview.chromium.org/2835323004/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/annotations.dart (right):

https://codereview.chromium.org/2835323004/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/annotations.dart:16: class Annotations {
another fun rename: OptimizerHintsForTests?

https://codereview.chromium.org/2835323004/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/annotations.dart:34: void
onLibraryLoaded(LibraryEntity library) {
btw - it might be nice to move all these lookups to common_elements instead and
get rid of this method.

It would also be nice to merge all the Optimizer hints together (we also have
ForceInline and NoInline in backend.dart)

[Johnni Winther, 2017-04-27 07:25:39]

https://codereview.chromium.org/2835323004/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/annotations.dart (right):

https://codereview.chromium.org/2835323004/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/annotations.dart:16: class Annotations {
On 2017/04/26 17:24:07, Siggi Cherem (dart-lang) wrote:
> another fun rename: OptimizerHintsForTests?

Done.

https://codereview.chromium.org/2835323004/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/annotations.dart:34: void
onLibraryLoaded(LibraryEntity library) {
On 2017/04/26 17:24:07, Siggi Cherem (dart-lang) wrote:
> btw - it might be nice to move all these lookups to common_elements instead
and
> get rid of this method.
> 
> It would also be nice to merge all the Optimizer hints together (we also have
> ForceInline and NoInline in backend.dart)

Done.

[Johnni Winther, 2017-04-27 07:31:06]

Description was changed from

==========
Handle @NoInline annotations in closed_world2_test

+ make closed_world_tester a bit more flexible.
==========

to

==========
Handle @NoInline annotations in closed_world2_test

+ make closed_world_tester a bit more flexible.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9b6eb81b012addd05d73f9fb15ce08f06e5ab9df
==========

[Johnni Winther, 2017-04-27 07:31:07]

Committed patchset #2 (id:20001) manually as
9b6eb81b012addd05d73f9fb15ce08f06e5ab9df (presubmit successful).

[Siggi Cherem (dart-lang), 2017-04-27 21:14:27]

thank you!