Handle @NoInline annotations in closed_world2_test

pkg/compiler/lib/src/js_backend/annotations.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library js_backend.backend.annotations;
 
 import '../common.dart';
 import '../common_elements.dart' show ElementEnvironment;
 import '../compiler.dart' show Compiler;
 import '../constants/values.dart';
 import '../elements/elements.dart';
 import '../elements/entities.dart';
 import 'backend.dart';
 
 /// Handling of special annotations for tests.
 class Annotations {

[Siggi Cherem (dart-lang), 2017/04/26 17:24:07]

another fun rename: OptimizerHintsForTests?

[Johnni Winther, 2017/04/27 07:25:39]

Done.

   static final Uri PACKAGE_EXPECT =
       new Uri(scheme: 'package', path: 'expect/expect.dart');
 
   final Compiler compiler;
 
-  ClassElement expectNoInlineClass;
-  ClassElement expectTrustTypeAnnotationsClass;
-  ClassElement expectAssumeDynamicClass;
+  ClassEntity expectNoInlineClass;
+  ClassEntity expectTrustTypeAnnotationsClass;
+  ClassEntity expectAssumeDynamicClass;
 
   JavaScriptBackend get backend => compiler.backend;
 
   DiagnosticReporter get reporter => compiler.reporter;
 
   ElementEnvironment get _elementEnvironment => compiler.elementEnvironment;
 
   Annotations(this.compiler);
 
   void onLibraryLoaded(LibraryEntity library) {

[Siggi Cherem (dart-lang), 2017/04/26 17:24:07]

btw - it might be nice to move all these lookups to common_elements instead and
get rid of this method.

It would also be nice to merge all the Optimizer hints together (we also have
ForceInline and NoInline in backend.dart)

[Johnni Winther, 2017/04/27 07:25:39]

Done.

     if (library.canonicalUri == PACKAGE_EXPECT) {
       expectNoInlineClass =
           _elementEnvironment.lookupClass(library, 'NoInline');
       expectTrustTypeAnnotationsClass =
           _elementEnvironment.lookupClass(library, 'TrustTypeAnnotations');
       expectAssumeDynamicClass =
           _elementEnvironment.lookupClass(library, 'AssumeDynamic');
       if (expectNoInlineClass == null ||
           expectTrustTypeAnnotationsClass == null ||
           expectAssumeDynamicClass == null) {
@@ skipping 38 matching lines @@
           ConstructedConstantValue constructedConstant = value;
           if (constructedConstant.type.element == annotationClass) {
             return true;
           }
         }
       }
       return false;
     });
   }
 }