Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2835243002: views: don't look for layers in ToggleButtonTest when ripples are disabled (Closed)

Created:
3 years, 8 months ago by Elly Fong-Jones
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/views/controls/button/toggle_button_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Elly Fong-Jones
TBRing this because I broke a test on some of the waterfall bots :(
3 years, 8 months ago (2017-04-24 17:33:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835243002/1
3 years, 8 months ago (2017-04-24 17:34:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0b2a55e0ffdce5f803763794025178f32fea18ab
3 years, 8 months ago (2017-04-24 17:51:06 UTC) #8
sky
3 years, 8 months ago (2017-04-24 19:18:47 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698