Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2835233005: Revert of Introduce a type of View background that stays in sync with its host (Closed)

Created:
3 years, 8 months ago by pkalinnikov
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sadrul, rogerm+autofillwatch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, msw+watch_chromium.org, awdf+watch_chromium.org, aboxhall+watch_chromium.org, sebsg+autofillwatch_chromium.org, rouslan+autofill_chromium.org, je_julie, vabr+watchlistautofill_chromium.org, kalyank, vabr+watchlistpasswordmanager_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, hcarmona+bubble_chromium.org, gcasto+watchlist_chromium.org, rouslan+bubble_chromium.org, groby+bubble_chromium.org, mathp+autofillwatch_chromium.org, tfarina, nektar+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce a type of View background that stays in sync with its host (patchset #10 id:180001 of https://codereview.chromium.org/2816193002/ ) Reason for revert: Seems causing a lot of test crashes on "Linux Chromium OS ASan" bots (ash_unittests, browser_tests, interactive_ui_tests, unit_tests). Original issue's description: > Introduce a type of View background that stays in sync with its host > View's native theme. > > This fixes a few bugs where we weren't using the right native theme, > whether by not updating after the NativeTheme changes or by trying to > access the NativeTheme before the View is added to a hierarchy (which > yields the default NativeTheme --- for most platforms, this didn't > effectively create a bug as there's only one NativeTheme). > > Best example is that now the sad tab respects the GTK native theme. > > Get rid of Ash's tray_constants::kBackgroundColor in favor of using the > bubble background color from the NativeTheme. > > BUG=711183, 693282 > TBR=stevenjb@chromium.org > > Review-Url: https://codereview.chromium.org/2816193002 > Cr-Commit-Position: refs/heads/master@{#466847} > Committed: https://chromium.googlesource.com/chromium/src/+/097f9cde453ea57eb4aa037f44add782391c5eb9 TBR=msw@chromium.org,tdanderson@chromium.org,stevenjb@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711183, 693282 Review-Url: https://codereview.chromium.org/2835233005 Cr-Commit-Position: refs/heads/master@{#466953} Committed: https://chromium.googlesource.com/chromium/src/+/1cf2905163bc2e0ec4ae52c533e751f4de7cde20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -145 lines) Patch
M ash/system/audio/volume_view.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/tray_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tray_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tray_details_view.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M ash/system/tray/tray_popup_utils.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/system/tray_accessibility.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/user/user_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/user/user_view.cc View 12 chunks +43 lines, -51 lines 0 comments Download
M chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 5 chunks +27 lines, -7 lines 0 comments Download
M ui/message_center/views/message_bubble_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/views/message_bubble_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/background.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/views/background.cc View 3 chunks +0 lines, -36 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M ui/views/view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/view_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pkalinnikov
Created Revert of Introduce a type of View background that stays in sync with its ...
3 years, 8 months ago (2017-04-25 12:30:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835233005/1
3 years, 8 months ago (2017-04-25 12:30:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1cf2905163bc2e0ec4ae52c533e751f4de7cde20
3 years, 8 months ago (2017-04-25 12:31:47 UTC) #6
Evan Stade
On 2017/04/25 12:31:47, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 8 months ago (2017-04-25 16:40:15 UTC) #7
pkalinnikov
You can look at builds #20817 and below here: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
3 years, 8 months ago (2017-04-25 17:02:25 UTC) #8
Evan Stade
3 years, 8 months ago (2017-04-25 21:51:07 UTC) #9
Message was sent while issue was closed.
On 2017/04/25 17:02:25, pkalinnikov wrote:
> You can look at builds #20817 and below here:
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

thanks!

Powered by Google App Engine
This is Rietveld 408576698