chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc b/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

index cf2554982dde13168eb27c6afab1d8a3b5e3227f..2c306acae962472fd128cad7298f39c7ef960640 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

@@ -10,6 +10,7 @@

#include "base/command_line.h"

#include "base/macros.h"

#include "base/memory/ptr_util.h"

+#include "base/threading/thread_restrictions.h"

#include "base/win/windows_version.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/lifetime/keep_alive_types.h"

@@ -236,8 +237,12 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTriggeredResetTest,

ProfileManager* profile_manager = g_browser_process->profile_manager();

base::FilePath path =

profile_manager->user_data_dir().AppendASCII("test_profile");

- Profile* other_profile =

- Profile::CreateProfile(path, nullptr, Profile::CREATE_MODE_SYNCHRONOUS);

+ Profile* other_profile = nullptr;

+ {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

+ other_profile =

+ Profile::CreateProfile(path, nullptr, Profile::CREATE_MODE_SYNCHRONOUS);

+ }

profile_manager->RegisterTestingProfile(other_profile, true, false);

// Use a couple same-site HTTP URLs.