chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc b/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

index 5279bce8375546bc5cbf567d7894c5316ac53432..d664dc8268a8ba9e805e99d98e1d0d4160948a93 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

@@ -7,6 +7,7 @@

#include "base/command_line.h"

#include "base/files/file_path.h"

#include "base/run_loop.h"

+#include "base/threading/thread_restrictions.h"

#include "build/build_config.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/prefs/session_startup_pref.h"

@@ -28,6 +29,7 @@ typedef InProcessBrowserTest StartupBrowserCreatorTest;

// And this test is useless without that functionality.

#if !defined(OS_CHROMEOS) && !defined(OS_MACOSX)

IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, LastUsedProfileActivated) {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

ProfileManager* profile_manager = g_browser_process->profile_manager();

// Create 4 profiles, they will be scheduled for destruction when the last