chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_browsertest.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc b/chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc

index 4b1f1c48510f55ee02a860340fe3abe4ca59836b..97a9cc7e61c9249b479f2b0b8973d545c40144bb 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc

@@ -15,6 +15,7 @@

#include "base/run_loop.h"

#include "base/strings/string_util.h"

#include "base/test/test_file_util.h"

+#include "base/threading/thread_restrictions.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/profiles/profile_window.h"

@@ -273,6 +274,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorCorruptProfileTest,

CloseBrowsersSynchronouslyForProfileBasePath("Profile 1");

CreateAndSwitchToProfile("Profile 2");

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

ASSERT_TRUE(base::CreateDirectory(ProfileManager::GetGuestProfilePath()));

ASSERT_TRUE(base::CreateDirectory(ProfileManager::GetSystemProfilePath()));

}

@@ -302,6 +304,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorCorruptProfileTest,

// Create the guest profile path, but not the system profile one. This will

// make it impossible to create the system profile once the permissions are

// locked down during setup.

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

ASSERT_TRUE(base::CreateDirectory(ProfileManager::GetGuestProfilePath()));

}

@@ -402,6 +405,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorCorruptProfileTest,

// manager instead.

IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorCorruptProfileTest,

PRE_DeletedProfileFallbackToUserManager) {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

ASSERT_TRUE(base::CreateDirectory(ProfileManager::GetGuestProfilePath()));

ASSERT_TRUE(base::CreateDirectory(ProfileManager::GetSystemProfilePath()));

}