Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2835213002:
cc: Add mask tiling unit tests (Closed)
Descriptioncc: Add mask tiling unit tests
This patch is intended to make existing cc unit tests test both
ways of mask tiling flag.
Notice that the cc pixel test is already testing multi texture
masks.
BUG=708582
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2835213002
Cr-Commit-Position: refs/heads/master@{#467323}
Committed: https://chromium.googlesource.com/chromium/src/+/f8cb0d0aaee74d9e4a01276a1ee366b65bc3261a
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix typo. #Messages
Total messages: 20 (13 generated)
Description was changed from ========== cc: Add mask tiling unit tests This patch is intended to add a cc pixel unit test for tiled masks and make existing cc unit tests test both ways of mask tiling flag. BUG=708582 ========== to ========== cc: Add mask tiling unit tests This patch is intended to add a cc pixel unit test for tiled masks and make existing cc unit tests test both ways of mask tiling flag. BUG=708582 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Description was changed from ========== cc: Add mask tiling unit tests This patch is intended to add a cc pixel unit test for tiled masks and make existing cc unit tests test both ways of mask tiling flag. BUG=708582 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Add mask tiling unit tests This patch is intended to make existing cc unit tests test both ways of mask tiling flag. Notice that the cc pixel test is already testing multi texture masks. BUG=708582 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
sunxd@chromium.org changed reviewers: + enne@chromium.org, trchen@chromium.org
The CQ bit was checked by sunxd@chromium.org to run a CQ dry run
PTAL.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm other than that typo It looks like the pixel tests are mostly testing multi texture masks? Can you list which are testing multi texture masks and which are testing single texture? Should all mask pixel tests test both versions? https://codereview.chromium.org/2835213002/diff/1/cc/trees/layer_tree_host_un... File cc/trees/layer_tree_host_unittest.cc (right): https://codereview.chromium.org/2835213002/diff/1/cc/trees/layer_tree_host_un... cc/trees/layer_tree_host_unittest.cc:6568: public: Accidental?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/24 18:31:30, enne wrote: > lgtm other than that typo > > It looks like the pixel tests are mostly testing multi texture masks? Can you > list which are testing multi texture masks and which are testing single texture? > Should all mask pixel tests test both versions? > > https://codereview.chromium.org/2835213002/diff/1/cc/trees/layer_tree_host_un... > File cc/trees/layer_tree_host_unittest.cc (right): > > https://codereview.chromium.org/2835213002/diff/1/cc/trees/layer_tree_host_un... > cc/trees/layer_tree_host_unittest.cc:6568: public: > Accidental? I think now pixel tests are all testing multiple texture mask. I'll add a copy of these tests that test Single texture mask.
I have corrected the typo, there will be a followup patch that updates pixel unit tests. https://codereview.chromium.org/2835213002/diff/1/cc/trees/layer_tree_host_un... File cc/trees/layer_tree_host_unittest.cc (right): https://codereview.chromium.org/2835213002/diff/1/cc/trees/layer_tree_host_un... cc/trees/layer_tree_host_unittest.cc:6568: public: On 2017/04/24 18:31:30, enne wrote: > Accidental? Done.
The CQ bit was checked by sunxd@chromium.org
The CQ bit was unchecked by sunxd@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sunxd@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2835213002/#ps20001 (title: "Fix typo.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493216919678840,
"parent_rev": "32d6602a55aba1ed93de09d56d4b1c722e7c98f7", "commit_rev":
"f8cb0d0aaee74d9e4a01276a1ee366b65bc3261a"}
Message was sent while issue was closed.
Description was changed from ========== cc: Add mask tiling unit tests This patch is intended to make existing cc unit tests test both ways of mask tiling flag. Notice that the cc pixel test is already testing multi texture masks. BUG=708582 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Add mask tiling unit tests This patch is intended to make existing cc unit tests test both ways of mask tiling flag. Notice that the cc pixel test is already testing multi texture masks. BUG=708582 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2835213002 Cr-Commit-Position: refs/heads/master@{#467323} Committed: https://chromium.googlesource.com/chromium/src/+/f8cb0d0aaee74d9e4a01276a1ee3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f8cb0d0aaee74d9e4a01276a1ee3... |
