DescriptionRevert of clean up printing::Image and printing::Metafile (patchset #7 id:140001 of https://codereview.chromium.org/2812263002/ )
Reason for revert:
Reverting so https://crrev.com/463828 can be cleanly reverted.
r463828 is likely causing https://crbug.com/712309
Original issue's description:
> clean up printing::Image and printing::Metafile
>
> printing::Image now takes raw data, rather than a metafile. this removes
> the need for a virtual on printing::Metafile, Playback().
> printing::Image gets move constructor
> printing::Image loses dead code.
>
> delete dead code: chrome/browser/printing/printing_layout_browsertest.cc
>
> ServiceUtilityProcessHost takes metafile data, not a MetafilePlayer. This will
> help remove printing::Metafile::SafePlayback().
>
> printing::PdfMetafileCg::OnRenderPage is added to copy data fewer times.
>
> Review-Url: https://codereview.chromium.org/2812263002
> Cr-Commit-Position: refs/heads/master@{#464714}
> Committed: https://chromium.googlesource.com/chromium/src/+/574b10750dfea3d1103946615a1c8a4a9bff3b5c
TBR=halcanary@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review-Url: https://codereview.chromium.org/2835193007
Cr-Commit-Position: refs/heads/master@{#467473}
Committed: https://chromium.googlesource.com/chromium/src/+/3109df1dc485aa29d6dba54f57a5762fd8957830
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|