Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2835193007: Revert of clean up printing::Image and printing::Metafile (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
hal.canary
CC:
chromium-reviews, mac-reviews_chromium.org, shrike
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clean up printing::Image and printing::Metafile (patchset #7 id:140001 of https://codereview.chromium.org/2812263002/ ) Reason for revert: Reverting so https://crrev.com/463828 can be cleanly reverted. r463828 is likely causing https://crbug.com/712309 Original issue's description: > clean up printing::Image and printing::Metafile > > printing::Image now takes raw data, rather than a metafile. this removes > the need for a virtual on printing::Metafile, Playback(). > printing::Image gets move constructor > printing::Image loses dead code. > > delete dead code: chrome/browser/printing/printing_layout_browsertest.cc > > ServiceUtilityProcessHost takes metafile data, not a MetafilePlayer. This will > help remove printing::Metafile::SafePlayback(). > > printing::PdfMetafileCg::OnRenderPage is added to copy data fewer times. > > Review-Url: https://codereview.chromium.org/2812263002 > Cr-Commit-Position: refs/heads/master@{#464714} > Committed: https://chromium.googlesource.com/chromium/src/+/574b10750dfea3d1103946615a1c8a4a9bff3b5c TBR=halcanary@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2835193007 Cr-Commit-Position: refs/heads/master@{#467473} Committed: https://chromium.googlesource.com/chromium/src/+/3109df1dc485aa29d6dba54f57a5762fd8957830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -78 lines) Patch
A chrome/browser/printing/printing_layout_browsertest.cc View 1 chunk +475 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/service/service_utility_process_host.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M components/printing/test/mock_printer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/mock_printer.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M printing/emf_win.h View 1 chunk +1 line, -11 lines 0 comments Download
M printing/image.h View 2 chunks +31 lines, -5 lines 0 comments Download
M printing/image.cc View 2 chunks +79 lines, -5 lines 0 comments Download
M printing/image_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image_mac.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M printing/image_win.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M printing/metafile.h View 2 chunks +17 lines, -0 lines 0 comments Download
M printing/pdf_metafile_cg_mac.h View 1 chunk +0 lines, -8 lines 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +1 line, -9 lines 0 comments Download
M printing/pdf_metafile_skia.h View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Lei Zhang
Created Revert of clean up printing::Image and printing::Metafile
3 years, 8 months ago (2017-04-26 20:36:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835193007/1
3 years, 8 months ago (2017-04-26 20:37:14 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 21:57:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3109df1dc485aa29d6dba54f57a5...

Powered by Google App Engine
This is Rietveld 408576698