Milo: Add timestamp name and tooltip

Milo: Add timestamp name and tooltip

This changes the timestamp to look like this:
* 2017-04-25 4:10 PM (PDT)

And add more text on hover

This adds moment.js and moment-timezone.js as dependencies.

BUG=700125
Review-Url: https://codereview.chromium.org/2835193006
Committed: https://github.com/luci/luci-go/commit/6f6782250520bb7b7b5aba2f6ec4fb6efecc2a15

[Ryan Tseng, 2017-04-25 23:41:45]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 23:41:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 23:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 23:46:03]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35c04fd0d3030610)

[Ryan Tseng, 2017-04-25 23:47:47]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 23:47:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2017-04-25 23:48:09]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org, nodir@chromium.org

[hinoka, 2017-04-25 23:48:09]

ptal.

See demo
https://1688-964f9c9-tainted-hinoka-dot-luci-milo-dev.appspot.com/buildbot/ch...

Also works on the builder page.

[commit-bot: I haz the power, 2017-04-26 00:00:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:00:37]

Dry run: This issue passed the CQ dry run.

[nodir, 2017-04-29 01:13:48]

On 2017/04/25 23:48:09, hinoka wrote:
> ptal.
> 
> See demo
>
https://1688-964f9c9-tainted-hinoka-dot-luci-milo-dev.appspot.com/buildbot/ch...

here is what i see http://imgur.com/a/2tHlS on that page

[nodir, 2017-04-29 01:26:40]

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
File
milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
(right):

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html:126:
data-endtime="2016-06-08T20:52:56Z"
please unindent

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
File milo/appengine/frontend/static/common/js/time.js (right):

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:1: // Copyright 2016 The LUCI
Authors. All rights reserved.
we should convert this to TypeScript at some point

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:38: * a duration string, with a
hover string of the start/end time int he user's
in the

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:52: if (et.isValid()) {
if start time is invalid, we return null, but if the end time is invalid, we
return an incomplete hover. This is inconsistent. What about returning null if
!et.IsValid() ?

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:90: console.error('could not
annotated duration', dur, e)
s/annotated/annotate/

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
File milo/appengine/frontend/templates/pages/build.html (right):

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/templates/pages/build.html:156: <span
style="float:right"
probably we will have more places where we need to express duration, so
repeating this code everywhere is not ideal. What about making a function or a
template that accepts duration, start time and end time and returns this span
with data-starttime date-endtime, etc

[Ryan Tseng, 2017-05-02 03:32:38]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 03:32:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2017-05-02 03:33:14]

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
File
milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
(right):

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html:126:
data-endtime="2016-06-08T20:52:56Z"
On 2017/04/29 01:26:40, nodir wrote:
> please unindent

Done.

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
File milo/appengine/frontend/static/common/js/time.js (right):

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:1: // Copyright 2016 The LUCI
Authors. All rights reserved.
On 2017/04/29 01:26:40, nodir wrote:
> we should convert this to TypeScript at some point

Acknowledged.

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:38: * a duration string, with a
hover string of the start/end time int he user's
On 2017/04/29 01:26:40, nodir wrote:
> in the

Done.

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:52: if (et.isValid()) {
On 2017/04/29 01:26:40, nodir wrote:
> if start time is invalid, we return null, but if the end time is invalid, we
> return an incomplete hover. This is inconsistent. What about returning null if
> !et.IsValid() ?

Done.

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/static/common/js/time.js:90: console.error('could not
annotated duration', dur, e)
On 2017/04/29 01:26:40, nodir wrote:
> s/annotated/annotate/

Done.

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
File milo/appengine/frontend/templates/pages/build.html (right):

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/templates/pages/build.html:156: <span
style="float:right"
On 2017/04/29 01:26:40, nodir wrote:
> probably we will have more places where we need to express duration, so
> repeating this code everywhere is not ideal. What about making a function or a
> template that accepts duration, start time and end time and returns this span
> with data-starttime date-endtime, etc

the span might need other things though, like styles/classes to make it float to
the right.  I could make one for this specific span, but then it'd have to
contain the code to make it float to the right...  It might be premature
optimization, wdyt?

[commit-bot: I haz the power, 2017-05-02 03:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 03:39:57]

Dry run: This issue passed the CQ dry run.

[nodir, 2017-05-02 14:58:02]

lgtm

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
File milo/appengine/frontend/templates/pages/build.html (right):

https://codereview.chromium.org/2835193006/diff/20001/milo/appengine/frontend...
milo/appengine/frontend/templates/pages/build.html:156: <span
style="float:right"
On 2017/05/02 03:33:14, hinoka wrote:
> On 2017/04/29 01:26:40, nodir wrote:
> > probably we will have more places where we need to express duration, so
> > repeating this code everywhere is not ideal. What about making a function or
a
> > template that accepts duration, start time and end time and returns this
span
> > with data-starttime date-endtime, etc
> 
> the span might need other things though, like styles/classes to make it float
to
> the right.  I could make one for this specific span, but then it'd have to
> contain the code to make it float to the right...  It might be premature
> optimization, wdyt?

It might be premature generalization

[hinoka, 2017-05-02 17:11:32]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:11:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:20:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493745092980200,
"parent_rev": "b559b5fa718707f6b108cbe4b593c17ad8647294", "commit_rev":
"6f6782250520bb7b7b5aba2f6ec4fb6efecc2a15"}

[commit-bot: I haz the power, 2017-05-02 17:20:43]

Description was changed from

==========
Milo: Add timestamp name and tooltip

This changes the timestamp to look like this:
* 2017-04-25 4:10 PM (PDT)

And add more text on hover

This adds moment.js and moment-timezone.js as dependencies.

BUG=700125
==========

to

==========
Milo: Add timestamp name and tooltip

This changes the timestamp to look like this:
* 2017-04-25 4:10 PM (PDT)

And add more text on hover

This adds moment.js and moment-timezone.js as dependencies.

BUG=700125

Review-Url: https://codereview.chromium.org/2835193006
Committed:
https://github.com/luci/luci-go/commit/6f6782250520bb7b7b5aba2f6ec4fb6efecc2a15
==========

[commit-bot: I haz the power, 2017-05-02 17:20:44]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/6f6782250520bb7b7b5aba2f6ec4fb6efecc2a15