Offline Pages - Policy cleanup

Offline Pages - Policy cleanup

This CL adds a client policy bit that controls whether namespaces are
disabled when prefetching-related prefs are disabled.

Also fixes an incorrect policy bit for the NTP articles namespace, it
was set to be cleared on cache when it was in fact a user-requested
data type.

Added some diagnostic information to the policy controller tests.

Paquete #fixit
BUG=705082
Review-Url: https://codereview.chromium.org/2835193005
Cr-Commit-Position: refs/heads/master@{#467518}
Committed: https://chromium.googlesource.com/chromium/src/+/d5b4d0051b79315b2084e758ca0f3b86043d729a

[dewittj, 2017-04-25 18:31:50]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 18:33:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2017-04-25 18:35:39]

Description was changed from

==========
Offline Pages - Policy cleanup

This CL adds a client policy bit that controls whether namespaces are
disabled when prefetching-related prefs are disabled.

Also fixes an incorrect policy bit for the NTP articles namespace, it
was set to be cleared on cache when it was in fact a user-requested
data type.

Added some diagnostic information to the policy controller tests.

Paquete #fixit
BUG=705082
==========

to

==========
Offline Pages - Policy cleanup

This CL adds a client policy bit that controls whether namespaces are
disabled when prefetching-related prefs are disabled.

Also fixes an incorrect policy bit for the NTP articles namespace, it
was set to be cleared on cache when it was in fact a user-requested
data type.

Added some diagnostic information to the policy controller tests.

Paquete #fixit
BUG=705082
==========

[dewittj, 2017-04-25 18:35:39]

dewittj@chromium.org changed reviewers:
+ chili@chromium.org, romax@chromium.org

[dewittj, 2017-04-25 18:37:39]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 18:38:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2017-04-25 18:38:25]

+chili for policy
+romax for changing the caching policy of NTP long-press downloads.

[romax, 2017-04-25 19:18:04]

lgtm with one typo.

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
File components/offline_pages/core/client_policy_controller_unittest.cc (right):

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
components/offline_pages/core/client_policy_controller_unittest.cc:58:
EXPECT_EQ(expectation, result != cache.end())
Thanks for the detailed messages!

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
File components/offline_pages/core/offline_page_client_policy.h (right):

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
components/offline_pages/core/offline_page_client_policy.h:58: // Whether the
namspace should be disabled if prefetching-related preferences
namspace -> namespace

[commit-bot: I haz the power, 2017-04-25 19:29:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:29:57]

Dry run: This issue passed the CQ dry run.

[dewittj, 2017-04-25 19:39:18]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[dewittj, 2017-04-25 19:39:42]

Thanks!

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
File components/offline_pages/core/client_policy_controller_unittest.cc (right):

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
components/offline_pages/core/client_policy_controller_unittest.cc:58:
EXPECT_EQ(expectation, result != cache.end())
On 2017/04/25 19:18:04, romax wrote:
> Thanks for the detailed messages!

Acknowledged.

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
File components/offline_pages/core/offline_page_client_policy.h (right):

https://codereview.chromium.org/2835193005/diff/20001/components/offline_page...
components/offline_pages/core/offline_page_client_policy.h:58: // Whether the
namspace should be disabled if prefetching-related preferences
On 2017/04/25 19:18:04, romax wrote:
> namspace -> namespace

Done.

[commit-bot: I haz the power, 2017-04-25 19:39:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:34:40]

Dry run: This issue passed the CQ dry run.

[chili, 2017-04-26 22:04:52]

lgtm

really like this!

[dewittj, 2017-04-26 22:09:10]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2017-04-26 22:09:10]

The patchset sent to the CQ was uploaded after l-g-t-m from romax@chromium.org
Link to the patchset: https://codereview.chromium.org/2835193005/#ps40001
(title: "Fix typo")

[commit-bot: I haz the power, 2017-04-26 22:09:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 23:52:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493244550566170,
"parent_rev": "362999207c6a8a108bdbf2d4ea7400e6ad0b2554", "commit_rev":
"d5b4d0051b79315b2084e758ca0f3b86043d729a"}

[commit-bot: I haz the power, 2017-04-26 23:52:56]

Description was changed from

==========
Offline Pages - Policy cleanup

This CL adds a client policy bit that controls whether namespaces are
disabled when prefetching-related prefs are disabled.

Also fixes an incorrect policy bit for the NTP articles namespace, it
was set to be cleared on cache when it was in fact a user-requested
data type.

Added some diagnostic information to the policy controller tests.

Paquete #fixit
BUG=705082
==========

to

==========
Offline Pages - Policy cleanup

This CL adds a client policy bit that controls whether namespaces are
disabled when prefetching-related prefs are disabled.

Also fixes an incorrect policy bit for the NTP articles namespace, it
was set to be cleared on cache when it was in fact a user-requested
data type.

Added some diagnostic information to the policy controller tests.

Paquete #fixit
BUG=705082

Review-Url: https://codereview.chromium.org/2835193005
Cr-Commit-Position: refs/heads/master@{#467518}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5b4d0051b79315b2084e758ca0f...
==========

[commit-bot: I haz the power, 2017-04-26 23:52:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d5b4d0051b79315b2084e758ca0f...