Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2835133004: [ES6 modules] Unit test ScriptModule::Evaluate (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, module-dev_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Unit test ScriptModule::Evaluate This CL introduces ScriptModuleTest.Evaluate to test ScriptModule::Evaulate(). BUG=594639 Review-Url: https://codereview.chromium.org/2835133004 Cr-Commit-Position: refs/heads/master@{#467100} Committed: https://chromium.googlesource.com/chromium/src/+/060877e899403501fab7d6cf1ee6c380f54c71fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-04-25 06:21:32 UTC) #2
kouhei (in TOK)
3 years, 8 months ago (2017-04-25 06:22:09 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-25 16:33:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835133004/1
3 years, 8 months ago (2017-04-25 20:25:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/060877e899403501fab7d6cf1ee6c380f54c71fe
3 years, 8 months ago (2017-04-25 20:36:29 UTC) #14
hiroshige
3 years, 8 months ago (2017-04-25 20:43:03 UTC) #15
Message was sent while issue was closed.
lgtm.

BTW how we should extensively unit unit test ScriptModule::Evaluate()? e.g. how
about cases with exception?
(The classic-script counter part of this, ScriptController, looks to have no
unit test though?)

Powered by Google App Engine
This is Rietveld 408576698