ash: Remove NetworkDetailedView.

ash: Remove NetworkDetailedView.

As NetworkWifiDetailedView bubble was transformed into notification,
now NetworkStateListDetailedView is the only subclass of
NetworkDetailedView. Therefore, the interface is no longer needed.

BUG=686206
Review-Url: https://codereview.chromium.org/2835133002
Cr-Commit-Position: refs/heads/master@{#467209}
Committed: https://chromium.googlesource.com/chromium/src/+/b0d84463b0969956171b6149d2a9f0a4c083c9f5

[tetsui2, 2017-04-24 11:11:32]

tetsui@google.com changed reviewers:
+ fukino@chromium.org, tdanderson@chromium.org

[tetsui2, 2017-04-24 11:11:32]

Please take a look. We discussed about this clean up CL in
https://codereview.chromium.org/2817423002/

[tdanderson, 2017-04-24 17:06:43]

Can you please run 'git cl try' from the command line (this is a good habit to
get into whenever you upload a CL)? Offhand I can see a couple of things that
will cause compilation failure, such as the #include of the newly-deleted file
in chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc

Please re-ping for a review once you've fixed up anything the trybots have
picked up.

[tetsui2, 2017-04-25 02:01:59]

The CQ bit was checked by tetsui@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 02:02:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 02:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 02:32:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tetsui2, 2017-04-25 08:51:34]

The CQ bit was checked by tetsui@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 08:51:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 09:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 09:51:29]

Dry run: This issue passed the CQ dry run.

[tetsui2, 2017-04-25 14:15:50]

tdanderson@: Sorry for my mistake. I fixed trybot build. Please take a look.
Thank you for your support and advice.

[tdanderson, 2017-04-25 14:52:22]

Thanks for taking care of this! LGTM with a couple of comments.

https://codereview.chromium.org/2835133002/diff/20001/ash/system/network/netw...
File ash/system/network/network_state_list_detailed_view.h (right):

https://codereview.chromium.org/2835133002/diff/20001/ash/system/network/netw...
ash/system/network/network_state_list_detailed_view.h:50: void Update();
nit: please move the deleted function-level documentation from Update() in
network_detailed_view.h to above Update() in this file.

https://codereview.chromium.org/2835133002/diff/20001/chrome/browser/ui/ash/n...
File chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc
(right):

https://codereview.chromium.org/2835133002/diff/20001/chrome/browser/ui/ash/n...
chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc:11:
#include "ash/system/network/network_state_list_detailed_view.h"
Ah sorry, I actually thought there were going to be some more compile issues
than just this which is why I asked you to run the trybots.

[tetsui2, 2017-04-26 00:04:37]

Thank you!

https://codereview.chromium.org/2835133002/diff/20001/ash/system/network/netw...
File ash/system/network/network_state_list_detailed_view.h (right):

https://codereview.chromium.org/2835133002/diff/20001/ash/system/network/netw...
ash/system/network/network_state_list_detailed_view.h:50: void Update();
On 2017/04/25 14:52:22, tdanderson wrote:
> nit: please move the deleted function-level documentation from Update() in
> network_detailed_view.h to above Update() in this file.

Done.

https://codereview.chromium.org/2835133002/diff/20001/chrome/browser/ui/ash/n...
File chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc
(right):

https://codereview.chromium.org/2835133002/diff/20001/chrome/browser/ui/ash/n...
chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc:11:
#include "ash/system/network/network_state_list_detailed_view.h"
On 2017/04/25 14:52:22, tdanderson wrote:
> Ah sorry, I actually thought there were going to be some more compile issues
> than just this which is why I asked you to run the trybots.

Acknowledged.

[tetsui2, 2017-04-26 00:04:44]

The CQ bit was checked by tetsui@google.com

[tetsui2, 2017-04-26 00:04:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2835133002/#ps40001
(title: "Move function level documentation.")

[commit-bot: I haz the power, 2017-04-26 00:05:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:18:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tetsui2, 2017-04-26 00:25:47]

tetsui@google.com changed reviewers:
+ jamescook@chromium.org

[tetsui2, 2017-04-26 00:25:49]

jamescook@: Could you give me OWNERS review for
chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc ? Thank
you.

[James Cook, 2017-04-26 01:06:30]

LGTM

https://codereview.chromium.org/2835133002/diff/40001/ash/system/network/netw...
File ash/system/network/network_state_list_detailed_view.h (right):

https://codereview.chromium.org/2835133002/diff/40001/ash/system/network/netw...
ash/system/network/network_state_list_detailed_view.h:53: //(Called only from
TrayNetworkStateObserver).
nit: space before (, or better yet eliminate this line entirely. These sorts of
comments quickly become stale.

[tetsui2, 2017-04-26 01:10:16]

Thank you for quick response.

https://codereview.chromium.org/2835133002/diff/40001/ash/system/network/netw...
File ash/system/network/network_state_list_detailed_view.h (right):

https://codereview.chromium.org/2835133002/diff/40001/ash/system/network/netw...
ash/system/network/network_state_list_detailed_view.h:53: //(Called only from
TrayNetworkStateObserver).
On 2017/04/26 01:06:30, James Cook wrote:
> nit: space before (, or better yet eliminate this line entirely. These sorts
of
> comments quickly become stale.

Done.

[tetsui2, 2017-04-26 01:10:24]

The CQ bit was checked by tetsui@google.com

[tetsui2, 2017-04-26 01:10:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2835133002/#ps60001
(title: "Remove comment.")

[commit-bot: I haz the power, 2017-04-26 01:11:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:35:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493169024374320,
"parent_rev": "c70a7b06bdfa97f21c7db551e2de61e3be34bf6a", "commit_rev":
"b0d84463b0969956171b6149d2a9f0a4c083c9f5"}

[commit-bot: I haz the power, 2017-04-26 02:36:09]

Description was changed from

==========
ash: Remove NetworkDetailedView.

As NetworkWifiDetailedView bubble was transformed into notification,
now NetworkStateListDetailedView is the only subclass of
NetworkDetailedView. Therefore, the interface is no longer needed.

BUG=686206
==========

to

==========
ash: Remove NetworkDetailedView.

As NetworkWifiDetailedView bubble was transformed into notification,
now NetworkStateListDetailedView is the only subclass of
NetworkDetailedView. Therefore, the interface is no longer needed.

BUG=686206

Review-Url: https://codereview.chromium.org/2835133002
Cr-Commit-Position: refs/heads/master@{#467209}
Committed:
https://chromium.googlesource.com/chromium/src/+/b0d84463b0969956171b6149d2a9...
==========

[commit-bot: I haz the power, 2017-04-26 02:36:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b0d84463b0969956171b6149d2a9...