Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2835053004: Mark the new Incognito NTP strings as translateable (Closed)

Created:
3 years, 8 months ago by msramek
Modified:
3 years, 8 months ago
Reviewers:
srahim, sdefresne
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark the new Incognito NTP strings as translateable ...since they have been finalized by now. TBR=sdefresne@chromium.org BUG=693525 Review-Url: https://codereview.chromium.org/2835053004 Cr-Commit-Position: refs/heads/master@{#466954} Committed: https://chromium.googlesource.com/chromium/src/+/cff2db73be7698c664ddbcf0625d4cb5b6f9246c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/new_or_sad_tab_strings.grdp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
msramek
Hi Shimi! At your request, I'm marking the Incognito strings as translateable. Please have a ...
3 years, 8 months ago (2017-04-25 01:34:48 UTC) #4
srahim
lgtm
3 years, 8 months ago (2017-04-25 02:16:19 UTC) #7
msramek
Thanks, Shimi! +Sylvain, I'll TBR you like the last time, since this is a tiny ...
3 years, 8 months ago (2017-04-25 12:29:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835053004/1
3 years, 8 months ago (2017-04-25 12:29:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cff2db73be7698c664ddbcf0625d4cb5b6f9246c
3 years, 8 months ago (2017-04-25 12:33:07 UTC) #15
sdefresne
3 years, 8 months ago (2017-04-25 14:20:46 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698