Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2835043004: MEDIA_LOG FFmpegAudioDecoder::ConfigureDecoder() channel mismatch (Closed)

Created:
3 years, 8 months ago by wolenetz
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MEDIA_LOG FFmpegAudioDecoder::ConfigureDecoder() channel mismatch Bug 705038 encountered a case where such channel mismatch occurred, but logs were insufficient in a release build. This change makes a previous DLOG instead do a MEDIA_LOG(ERROR) for this specific case. BUG=714730, 705038 Review-Url: https://codereview.chromium.org/2835043004 Cr-Commit-Position: refs/heads/master@{#466785} Committed: https://chromium.googlesource.com/chromium/src/+/854dede8e4cb7885e803e9e7f3223f00e89a6d38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
wolenetz
Please take a look. With the repro that hits this log (https://bugs.chromium.org/p/chromium/issues/detail?id=705038#c16), the produced MediaError ...
3 years, 8 months ago (2017-04-24 19:50:26 UTC) #2
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-24 20:22:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835043004/1
3 years, 8 months ago (2017-04-24 20:42:39 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 22:01:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/854dede8e4cb7885e803e9e7f322...

Powered by Google App Engine
This is Rietveld 408576698