Mac: Add tooltip to download item.

Mac: Add tooltip to download item.

BUG=41195
TEST=Download file with long name. Dangerous download view shouldn't have tooltip, normal download button should.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51680

[viettrungluu, 2010-07-07 00:09:54]

http://codereview.chromium.org/2835036/diff/4001/5001
File chrome/browser/cocoa/download_item_controller.h (right):

http://codereview.chromium.org/2835036/diff/4001/5001#newcode1
chrome/browser/cocoa/download_item_controller.h:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
2010

http://codereview.chromium.org/2835036/diff/4001/5001#newcode90
chrome/browser/cocoa/download_item_controller.h:90: - (void)updateToolTip;
Apparently the single compound word "tooltip" gets a studly 'T' in the middle.
But this appears to be consistent with the progressView_'s method. Sigh.

http://codereview.chromium.org/2835036/diff/4001/5002
File chrome/browser/cocoa/download_item_controller.mm (right):

http://codereview.chromium.org/2835036/diff/4001/5002#newcode40
chrome/browser/cocoa/download_item_controller.mm:40: const int kToolTipMaxWidth
= 1000;
From where did you pull this maximum width? <shrug>

http://codereview.chromium.org/2835036/diff/4001/5002#newcode263
chrome/browser/cocoa/download_item_controller.mm:263: std::wstring
elidedFilename = gfx::ElideFilename(
We're obviously much too lazy to get rid of wstrings.

http://codereview.chromium.org/2835036/diff/4001/5002#newcode264
chrome/browser/cocoa/download_item_controller.mm:264: [self
download]->GetFileName(),
Plus I hate your line-breaking. Consider breaking as:

  std::wstring elidedFilename =
      gfx::ElideFilename([self download]->GetFileName(), gfx::Font(),
                         kToolTipMaxWidth);

or similar

http://codereview.chromium.org/2835036/diff/4001/5003
File chrome/browser/cocoa/download_item_mac.mm (right):

http://codereview.chromium.org/2835036/diff/4001/5003#newcode1
chrome/browser/cocoa/download_item_mac.mm:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
2010

[Nico, 2010-07-07 00:17:18]

Consider sending "LG" with your comments if you have only nits.

http://codereview.chromium.org/2835036/diff/4001/5001
File chrome/browser/cocoa/download_item_controller.h (right):

http://codereview.chromium.org/2835036/diff/4001/5001#newcode1
chrome/browser/cocoa/download_item_controller.h:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
On 2010/07/07 00:09:54, viettrungluu wrote:
> 2010

Done.

(Also: Srsly?)

http://codereview.chromium.org/2835036/diff/4001/5001#newcode90
chrome/browser/cocoa/download_item_controller.h:90: - (void)updateToolTip;
On 2010/07/07 00:09:54, viettrungluu wrote:
> Apparently the single compound word "tooltip" gets a studly 'T' in the middle.
> But this appears to be consistent with the progressView_'s method. Sigh.

Yes, this is how cocoa rolls.

http://codereview.chromium.org/2835036/diff/4001/5002
File chrome/browser/cocoa/download_item_controller.mm (right):

http://codereview.chromium.org/2835036/diff/4001/5002#newcode40
chrome/browser/cocoa/download_item_controller.mm:40: const int kToolTipMaxWidth
= 1000;
On 2010/07/07 00:09:54, viettrungluu wrote:
> From where did you pull this maximum width? <shrug>

gtk. Also, it's smaller than 1024, the smallest display resolution that chrome
runs on in practice. I guess I could change it to 900 to make room for a huge
side dock (whch appears to be ~120 px). Done.

http://codereview.chromium.org/2835036/diff/4001/5002#newcode264
chrome/browser/cocoa/download_item_controller.mm:264: [self
download]->GetFileName(),
On 2010/07/07 00:09:54, viettrungluu wrote:
> Plus I hate your line-breaking. Consider breaking as:
> 
>   std::wstring elidedFilename =
>       gfx::ElideFilename([self download]->GetFileName(), gfx::Font(),
>                          kToolTipMaxWidth);
> 
> or similar

I like it as is *shrug*

[Nico, 2010-07-07 00:17:33]

http://codereview.chromium.org/2835036/diff/4001/5003
File chrome/browser/cocoa/download_item_mac.mm (right):

http://codereview.chromium.org/2835036/diff/4001/5003#newcode1
chrome/browser/cocoa/download_item_mac.mm:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
On 2010/07/07 00:09:54, viettrungluu wrote:
> 2010

Done.

[viettrungluu, 2010-07-07 02:32:03]

On 2010/07/07 00:17:18, Nico wrote:
> Consider sending "LG" with your comments if you have only nits.

Wait for the LG, despite the oversight. Else I'm disinclined to review.