Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2835033002: Revert of Replace TabModel with WebStateList in GoogleLandingController. (Closed)

Created:
3 years, 8 months ago by justincohen
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, ios-reviews+clean_chromium.org, lpromero+watch_chromium.org, marq+scrutinize_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace TabModel with WebStateList in GoogleLandingController. (patchset #7 id:110001 of https://codereview.chromium.org/2833513002/ ) Reason for revert: Broke downstream eg tests, needs some minor fixes. Original issue's description: > Replace TabModel with WebStateList in GoogleLandingController. > > BUG=694750 > > Review-Url: https://codereview.chromium.org/2833513002 > Cr-Commit-Position: refs/heads/master@{#466542} > Committed: https://chromium.googlesource.com/chromium/src/+/892edbbf57698e574b6b2b15481239af1c5c4ede TBR=rohitrao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=694750 Review-Url: https://codereview.chromium.org/2835033002 Cr-Commit-Position: refs/heads/master@{#466563} Committed: https://chromium.googlesource.com/chromium/src/+/a3eecd718f060080ce740a75fc6fa57a2b9061ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -77 lines) Patch
M ios/chrome/browser/ui/ntp/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_consumer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_controller.mm View 4 chunks +0 lines, -10 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_controller_unittest.mm View 3 chunks +1 line, -6 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_data_source.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_mediator.h View 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_mediator.mm View 9 chunks +8 lines, -33 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm View 5 chunks +1 line, -10 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_header_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_header_view.mm View 5 chunks +14 lines, -3 lines 0 comments Download
M ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
justincohen
Created Revert of Replace TabModel with WebStateList in GoogleLandingController.
3 years, 8 months ago (2017-04-23 14:46:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835033002/1
3 years, 8 months ago (2017-04-23 14:46:56 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-23 14:47:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3eecd718f060080ce740a75fc6f...

Powered by Google App Engine
This is Rietveld 408576698