Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2835023002: Remove obsolete chrome://settings/power redirect for MD Settings (Closed)

Created:
3 years, 8 months ago by michaelpg
Modified:
3 years, 8 months ago
Reviewers:
*msw, Daniel Erat
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete chrome://settings/power redirect for MD Settings chrome://settings/power in MD Settings now exists as a subpage, as in old Options, so allow navigation there instead of redirecting to the top-level Device section. A click on a USB dual-role notification will now open the Power subpage directly. BUG=633455 Review-Url: https://codereview.chromium.org/2835023002 Cr-Commit-Position: refs/heads/master@{#466726} Committed: https://chromium.googlesource.com/chromium/src/+/be955b43265817336cd940d144cd05a0e1c8495a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/ui/chrome_pages.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
michaelpg
msw@ for OWNERS, derat@ for sanity. Thanks!
3 years, 8 months ago (2017-04-22 23:20:45 UTC) #4
Daniel Erat
lgtm
3 years, 8 months ago (2017-04-24 04:14:00 UTC) #5
msw
lgtm
3 years, 8 months ago (2017-04-24 17:29:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835023002/1
3 years, 8 months ago (2017-04-24 19:23:17 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 20:04:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be955b43265817336cd940d144cd...

Powered by Google App Engine
This is Rietveld 408576698