Chromium Code Reviews Chromium Code Reviews
Issue 2835014:
Make the apply.js unit test more resilient to differing stack positions.... (Closed)
Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/| OLD | NEW |
|---|---|
| 1 # Copyright 2008 the V8 project authors. All rights reserved. | 1 # Copyright 2008 the V8 project authors. All rights reserved. |
| 2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
| 3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
| 4 # met: | 4 # met: |
| 5 # | 5 # |
| 6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
| 7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
| 8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
| 9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
| 10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 27 | 27 |
| 28 prefix mjsunit | 28 prefix mjsunit |
| 29 | 29 |
| 30 # All tests in the bug directory are expected to fail. | 30 # All tests in the bug directory are expected to fail. |
| 31 bugs: FAIL | 31 bugs: FAIL |
| 32 | 32 |
| 33 # This one uses a built-in that's only present in debug mode. It takes | 33 # This one uses a built-in that's only present in debug mode. It takes |
| 34 # too long to run in debug mode on ARM. | 34 # too long to run in debug mode on ARM. |
| 35 fuzz-natives: PASS, SKIP if ($mode == release || $arch == arm) | 35 fuzz-natives: PASS, SKIP if ($mode == release || $arch == arm) |
| 36 | 36 |
| 37 # Issue 494: new snapshot code breaks mjsunit/apply on mac debug snapshot. | |
| 38 apply: PASS, FAIL if ($system == macos && $mode == debug) | |
| 39 | |
|
zarko
2010/06/22 21:48:20
Is this sufficient to re-enable the test?
Vitaly Repeshko
2010/06/22 22:01:47
I think so, yes. After submitting you can check st
| |
| 40 big-object-literal: PASS, SKIP if ($arch == arm) | 37 big-object-literal: PASS, SKIP if ($arch == arm) |
| 41 | 38 |
| 42 # Issue 488: this test sometimes times out. | 39 # Issue 488: this test sometimes times out. |
| 43 array-constructor: PASS || TIMEOUT | 40 array-constructor: PASS || TIMEOUT |
| 44 | 41 |
| 45 # Very slow on ARM, contains no architecture dependent code. | 42 # Very slow on ARM, contains no architecture dependent code. |
| 46 unicode-case-overoptimization: PASS, TIMEOUT if ($arch == arm) | 43 unicode-case-overoptimization: PASS, TIMEOUT if ($arch == arm) |
| 47 | 44 |
| 48 # Skip long running test in debug and allow it to timeout in release mode. | 45 # Skip long running test in debug and allow it to timeout in release mode. |
| 49 regress/regress-524: (PASS || TIMEOUT), SKIP if $mode == debug | 46 regress/regress-524: (PASS || TIMEOUT), SKIP if $mode == debug |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 73 debug-liveedit-check-stack: SKIP | 70 debug-liveedit-check-stack: SKIP |
| 74 | 71 |
| 75 # Skip all tests on MIPS. | 72 # Skip all tests on MIPS. |
| 76 *: SKIP | 73 *: SKIP |
| 77 | 74 |
| 78 [ $arch == x64 ] | 75 [ $arch == x64 ] |
| 79 # Stack manipulations in LiveEdit is implemented for ia32 only. | 76 # Stack manipulations in LiveEdit is implemented for ia32 only. |
| 80 debug-liveedit-check-stack: SKIP | 77 debug-liveedit-check-stack: SKIP |
| 81 | 78 |
| 82 | 79 |
| OLD | NEW |
