Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2834863002: [TTS] Add an OWNERS for junit and update OWNERS. (Closed)

Created:
3 years, 8 months ago by Donn Denman
Modified:
3 years, 8 months ago
Reviewers:
Theresa, Maria
CC:
chromium-reviews, twellington+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Add an OWNERS for junit and update OWNERS. Adds an OWNERS to the junit contextualsearch directory so we can add more tests without needing a review from outside the CS team. Also update all our other OWNERS files with TEAM and COMPONENT information. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2834863002 Cr-Commit-Position: refs/heads/master@{#466457} Committed: https://chromium.googlesource.com/chromium/src/+/d7f8bc6d4d9ae91386a0099e48dd48c1d8bdc6eb

Patch Set 1 #

Patch Set 2 : Added c/a/junit/.../contextualsearch/OWNERS (missed it in the last patch). #

Messages

Total messages: 22 (13 generated)
Donn Denman
Theresa, PTAL.
3 years, 8 months ago (2017-04-21 18:46:10 UTC) #7
Theresa
lgtm
3 years, 8 months ago (2017-04-21 20:07:35 UTC) #8
Donn Denman
Maria, PTAL at chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OWNERS, thanks!
3 years, 8 months ago (2017-04-21 20:39:10 UTC) #10
Maria
lgtm
3 years, 8 months ago (2017-04-21 21:00:17 UTC) #11
Donn Denman
Thanks for the review!
3 years, 8 months ago (2017-04-21 21:28:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834863002/1
3 years, 8 months ago (2017-04-21 21:29:14 UTC) #14
Donn Denman
Forgot c/a/junit/.../contextualsearch/OWNERS, added now, will commit rather than bother you for another review.
3 years, 8 months ago (2017-04-21 21:32:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834863002/20001
3 years, 8 months ago (2017-04-21 21:33:34 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 21:47:16 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d7f8bc6d4d9ae91386a0099e48dd...

Powered by Google App Engine
This is Rietveld 408576698