Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2834853002: [grokdump] Include -z flag to make objdump disassemble all-zero sections (Closed)

Created:
3 years, 8 months ago by Jakob Kummerow
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[grokdump] Include -z flag to make objdump disassemble all-zero sections NOTRY=true Review-Url: https://codereview.chromium.org/2834853002 Cr-Commit-Position: refs/heads/master@{#44777} Committed: https://chromium.googlesource.com/v8/v8/+/d549260a5e9ba990d13660946a005fc03a208063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/disasm.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jakob Kummerow
PTAL.
3 years, 8 months ago (2017-04-21 13:26:46 UTC) #2
Jarin
lgtm, thanks!
3 years, 8 months ago (2017-04-21 13:32:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834853002/1
3 years, 8 months ago (2017-04-21 13:34:07 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 13:35:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d549260a5e9ba990d13660946a005fc03a2...

Powered by Google App Engine
This is Rietveld 408576698