Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2834743002: macOS: Use MADV_FREE_REUSABLE for discardable shared memory. (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, danakj+watch_chromium.org, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

macOS: Use MADV_FREE_REUSABLE for discardable shared memory. MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the reusable bit, which allows both Activity Monitor and memory-infra to correctly track the pages. BUG=713892 Review-Url: https://codereview.chromium.org/2834743002 Cr-Commit-Position: refs/heads/master@{#466280} Committed: https://chromium.googlesource.com/chromium/src/+/61f066322d740afe3e2b17789fbc8960ed56558b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M base/memory/discardable_shared_memory.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
erikchen
mark: Please review.
3 years, 8 months ago (2017-04-20 22:12:33 UTC) #3
Mark Mentovai
LGTM
3 years, 8 months ago (2017-04-21 03:21:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834743002/1
3 years, 8 months ago (2017-04-21 07:06:24 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 07:10:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61f066322d740afe3e2b17789fbc...

Powered by Google App Engine
This is Rietveld 408576698