Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2834733003: Separate preaload matching from MemoryCache (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 7 months ago
Reviewers:
Yoav Weiss, Nate Chapin
CC:
chromium-reviews, Yoav Weiss, gavinp+prerender_chromium.org, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate preaload matching from MemoryCache This change decouples preload matching from MemoryCache lookup. With this change, preload matching is done for ResourceFetcher::prealods_. This is the first step and part of the second step in the design document[1]. 1: https://docs.google.com/document/d/1oq8ixPnaDxuAlKUTRQ3WoYHlJenVkzNU9xnkuZX_dWM/edit# BUG=695939 Review-Url: https://codereview.chromium.org/2834733003 Cr-Commit-Position: refs/heads/master@{#469046} Committed: https://chromium.googlesource.com/chromium/src/+/bb924e1897f5b4c67325dbfbdf2441e7f0686d53

Patch Set 1 : fix #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Total comments: 8

Patch Set 4 : rebase #

Patch Set 5 : fix #

Patch Set 6 : fix #

Patch Set 7 : fix #

Total comments: 2

Patch Set 8 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -159 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/resources/srcset-helper.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/permissionclient/image-permissions-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h View 1 2 3 4 1 chunk +71 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 3 5 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 2 3 4 5 6 7 11 chunks +167 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp View 1 2 3 6 chunks +124 lines, -58 lines 0 comments Download

Messages

Total messages: 107 (98 generated)
yhirano
https://codereview.chromium.org/2834733003/diff/300001/third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html File third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html (left): https://codereview.chromium.org/2834733003/diff/300001/third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html#oldcode21 third_party/WebKit/LayoutTests/http/tests/preload/multiple-meta-csp.html:21: assert_true(internals.isPreloaded('../resources/testharnessreport.js')); In this test, speculative preloads are made AFTER ...
3 years, 8 months ago (2017-04-25 14:47:30 UTC) #67
yhirano
+japhet@, yoav@
3 years, 8 months ago (2017-04-26 01:31:10 UTC) #69
yhirano
On 2017/04/26 01:31:10, yhirano wrote: > +japhet@, yoav@ ping
3 years, 7 months ago (2017-05-01 14:37:17 UTC) #78
Nate Chapin
Sorry for the delay... https://codereview.chromium.org/2834733003/diff/340001/third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h File third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h (right): https://codereview.chromium.org/2834733003/diff/340001/third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h#newcode44 third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h:44: static KURL FragmentRemovedUrl(const KURL& src) ...
3 years, 7 months ago (2017-05-02 00:02:16 UTC) #79
yhirano
https://codereview.chromium.org/2834733003/diff/340001/third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h File third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h (right): https://codereview.chromium.org/2834733003/diff/340001/third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h#newcode44 third_party/WebKit/Source/platform/loader/fetch/PreloadKey.h:44: static KURL FragmentRemovedUrl(const KURL& src) { On 2017/05/02 00:02:16, ...
3 years, 7 months ago (2017-05-02 10:22:18 UTC) #94
Nate Chapin
LGTM https://codereview.chromium.org/2834733003/diff/420001/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp File third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/2834733003/diff/420001/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp#newcode876 third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp:876: if (!(params.IsSpeculativePreload() || params.IsLinkPreload())) Nit: I prefer to ...
3 years, 7 months ago (2017-05-02 23:06:32 UTC) #97
yhirano
https://codereview.chromium.org/2834733003/diff/420001/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp File third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/2834733003/diff/420001/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp#newcode876 third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp:876: if (!(params.IsSpeculativePreload() || params.IsLinkPreload())) On 2017/05/02 23:06:31, Nate Chapin ...
3 years, 7 months ago (2017-05-03 16:34:19 UTC) #100
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834733003/440001
3 years, 7 months ago (2017-05-03 16:35:02 UTC) #104
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:43:03 UTC) #107
Message was sent while issue was closed.
Committed patchset #8 (id:440001) as
https://chromium.googlesource.com/chromium/src/+/bb924e1897f5b4c67325dbfbdf24...

Powered by Google App Engine
This is Rietveld 408576698