Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 2834723002: Landing Recent QUIC changes until Thu Apr 20 2017 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Ryan Hamilton
Modified:
2 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until Thu Apr 20 2017 Convert QUIC non-feature flags to the old syntax, for consistency. Merge internal change: 153720286 https://codereview.chromium.org/2828163005/ Increases inflight limit for QUIC BBR if the ack rate in the past half-rtt was lower than half the current bandwidth estimate. Protected by FLAGS_quic_reloadable_flag_quic_bbr_slow_recent_delivery. Merge internal change: 153663187 https://codereview.chromium.org/2833673006/ Include unistd.h in quic_socket_utils.cc Merge internal change: 153540629 https://codereview.chromium.org/2835473003/ Remain in packet conservation mode if BBR is in PROBE_BW and not in high-gain mode. Protected by FLAGS_quic_reloadable_flag_quic_bbr_extra_conservation. Merge internal change: 153506591 https://codereview.chromium.org/2832003002/ Review-Url: https://codereview.chromium.org/2834723002 Cr-Commit-Position: refs/heads/master@{#466169} Committed: https://chromium.googlesource.com/chromium/src/+/fa4a3abeb4b71666715a342e4e158d1d084bb5b4

Patch Set 1 #

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -29 lines) Patch
M net/quic/core/congestion_control/bbr_sender.h View 4 chunks +29 lines, -1 line 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 1 6 chunks +98 lines, -5 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 7 chunks +52 lines, -5 lines 0 comments Download
M net/quic/core/congestion_control/send_algorithm_interface.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_base.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +13 lines, -0 lines 0 comments Download
M net/quic/core/quic_version_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_version_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_versions.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_versions_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/platform/impl/quic_socket_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 15 (11 generated)
Ryan Hamilton
2 months ago (2017-04-20 19:39:16 UTC) #3
Jana
lgtm
2 months ago (2017-04-20 19:48:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834723002/20001
2 months ago (2017-04-20 21:28:43 UTC) #12
commit-bot: I haz the power
2 months ago (2017-04-20 22:37:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa4a3abeb4b71666715a342e4e15...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318