Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 2834643002: audioproc_f with simulated mic analog gain

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by AleBzk
Modified:
1 day, 22 hours ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

audioproc_f with simulated mic analog gain Make use of the gain suggested by AGC in audioproc_f by simulating analog gain applied to the mic. The simulation is done by applying digital gain to the input samples. This functionality is optional and disabled by default. If an AECdump is provided and the mic gain simulation is active, the suggested gains are only used if the AECdump does *not* contain the sequence of suggested gains. BUG=webrtc:7494

Patch Set 1 : set_stream_analog_level and stream_analog_level moved into parent class AudioProcessingSimulator #

Total comments: 13

Patch Set 2 : Comments from Alex addressed #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -27 lines) Patch
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc View 1 4 chunks +17 lines, -15 lines 3 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.h View 1 4 chunks +8 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.cc View 1 2 chunks +19 lines, -1 line 5 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 2 chunks +4 lines, -0 lines 1 comment Download
M webrtc/modules/audio_processing/test/wav_based_simulator.h View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/wav_based_simulator.cc View 3 chunks +2 lines, -8 lines 1 comment Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 18 (7 generated)
AleBzk
Hi Alex, This is a first patch set with some changes (incl. missing imports notified ...
1 week ago (2017-04-21 09:43:46 UTC) #4
aleloi
What will happen if we always do the gain control level updating instead of passing ...
1 week ago (2017-04-21 11:46:43 UTC) #5
aleloi
https://codereview.webrtc.org/2834643002/diff/20001/webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc File webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc (right): https://codereview.webrtc.org/2834643002/diff/20001/webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc#newcode164 webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc:164: // If so and the analog gain simulation is ...
1 week ago (2017-04-21 11:52:29 UTC) #6
AleBzk
Hi Alex, Thanks a lot for your comments. PTAL, once you don't have further comments, ...
4 days, 21 hours ago (2017-04-24 09:40:26 UTC) #7
aleloi
lgtm
4 days, 19 hours ago (2017-04-24 11:48:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2834643002/40001
2 days, 21 hours ago (2017-04-26 09:40:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16458)
2 days, 21 hours ago (2017-04-26 09:45:01 UTC) #12
AleBzk
I added Henrik, we need approval from one of the owners.
2 days, 21 hours ago (2017-04-26 09:47:29 UTC) #14
hlundin-webrtc
I'm having difficulties understanding the logic. https://codereview.webrtc.org/2834643002/diff/40001/webrtc/modules/audio_processing/test/audio_processing_simulator.cc File webrtc/modules/audio_processing/test/audio_processing_simulator.cc (right): https://codereview.webrtc.org/2834643002/diff/40001/webrtc/modules/audio_processing/test/audio_processing_simulator.cc#newcode132 webrtc/modules/audio_processing/test/audio_processing_simulator.cc:132: last_specified_microphone_level_ = settings_.simulate_mic_gain ...
2 days, 19 hours ago (2017-04-26 12:11:37 UTC) #15
peah-webrtc
Some drive-by comments. https://codereview.webrtc.org/2834643002/diff/40001/webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc File webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc (right): https://codereview.webrtc.org/2834643002/diff/40001/webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc#newcode163 webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc:163: // If the AECdump does not ...
2 days, 18 hours ago (2017-04-26 12:54:44 UTC) #17
AleBzk
2 days, 17 hours ago (2017-04-26 14:19:33 UTC) #18
Thanks for all your comments. I think it's best to discuss the changes offline
before I upload a new PS.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46