chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java - Issue 2834633002: [Android O] Add SystemNotification.ChannelBlocked histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java

Issue 2834633002: [Android O] Add SystemNotification.ChannelBlocked histogram (Closed)

Patch Set: Add comment explaining reflection Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java

index 15a568d5e61ed0f08f2ee835e25db3fe81f33558..db8c414e26c1ba9254b96ed1c2850ba28edecf19 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java

@@ -51,7 +51,7 @@ public class IncognitoNotificationManager {

(NotificationManager) context.getSystemService(Context.NOTIFICATION_SERVICE);

nm.notify(INCOGNITO_TABS_OPEN_TAG, INCOGNITO_TABS_OPEN_ID, builder.build());

NotificationUmaTracker.getInstance().onNotificationShown(

- NotificationUmaTracker.CLOSE_INCOGNITO);

+ NotificationUmaTracker.CLOSE_INCOGNITO, ChannelDefinitions.CHANNEL_ID_INCOGNITO);

}

/**