chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java - Issue 2834633002: [Android O] Add SystemNotification.ChannelBlocked histogram

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Issue 2834633002: [Android O] Add SystemNotification.ChannelBlocked histogram (Closed)

Patch Set: Add comment explaining reflection Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

index 1b367f6651c8c806616a446c31aaad099d94b8be..738406b14a526cdea0925adce984ff05b00c18bc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

@@ -1333,7 +1333,8 @@ public class DownloadNotificationService extends Service {

if (mDownloadSharedPreferenceHelper.hasEntry(id)) return;

NotificationUmaTracker.getInstance().onNotificationShown(

LegacyHelpers.isLegacyOfflinePage(id) ? NotificationUmaTracker.DOWNLOAD_PAGES

- : NotificationUmaTracker.DOWNLOAD_FILES);

+ : NotificationUmaTracker.DOWNLOAD_FILES,

+ ChannelDefinitions.CHANNEL_ID_DOWNLOADS);

}

/**

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java » ('j') | no next file with comments »