Verify GpuService During FrameSink Creation

Verify GpuService During FrameSink Creation

When running mash_browser_tests there is a flaky crash, where
GpuMain::CreateFrameSinkManagerInternal seg faults on startup. We currently do
not have enough details to determine the cause of this crash.

This change adds an early DCHECK that the GpuService has been created. To see
if we have a race condition in service startup.

TEST=manually ran chrome --mash, mash_browser_tests
BUG=712669
Review-Url: https://codereview.chromium.org/2834623003
Cr-Commit-Position: refs/heads/master@{#466162}
Committed: https://chromium.googlesource.com/chromium/src/+/1973201a14f00d6d1ac084ea4afbd4744f5e8f97

[jonross, 2017-04-20 21:17:31]

jonross@chromium.org changed reviewers:
+ fsamuel@chromium.org

[jonross, 2017-04-20 21:17:32]

Hey Fady,

here's the DCHECK we talked about. PTAL

Thanks,
Jon

[Fady Samuel, 2017-04-20 21:18:41]

lgtm

[jonross, 2017-04-20 21:19:22]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:20:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:22:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492723162689720, "parent_rev":
"c2a141ce2ea4ea1a2826861798370bb91866f620", "commit_rev":
"1973201a14f00d6d1ac084ea4afbd4744f5e8f97"}

[commit-bot: I haz the power, 2017-04-20 22:22:23]

Description was changed from

==========
Verify GpuService During FrameSink Creation

When running mash_browser_tests there is a flaky crash, where
GpuMain::CreateFrameSinkManagerInternal seg faults on startup. We currently do
not have enough details to determine the cause of this crash.

This change adds an early DCHECK that the GpuService has been created. To see
if we have a race condition in service startup.

TEST=manually ran chrome --mash, mash_browser_tests
BUG=712669
==========

to

==========
Verify GpuService During FrameSink Creation

When running mash_browser_tests there is a flaky crash, where
GpuMain::CreateFrameSinkManagerInternal seg faults on startup. We currently do
not have enough details to determine the cause of this crash.

This change adds an early DCHECK that the GpuService has been created. To see
if we have a race condition in service startup.

TEST=manually ran chrome --mash, mash_browser_tests
BUG=712669

Review-Url: https://codereview.chromium.org/2834623003
Cr-Commit-Position: refs/heads/master@{#466162}
Committed:
https://chromium.googlesource.com/chromium/src/+/1973201a14f00d6d1ac084ea4afb...
==========

[commit-bot: I haz the power, 2017-04-20 22:22:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1973201a14f00d6d1ac084ea4afb...