Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2834623002: [ObjC ARC] Converts ios/chrome/browser/ui/settings/utils:test_support to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/settings/utils:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2834623002 Cr-Commit-Position: refs/heads/master@{#465990} Committed: https://chromium.googlesource.com/chromium/src/+/45d637552defb050205b9a1301b6c540a39dda0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/settings/utils/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/utils/fake_observable_boolean.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-20 11:58:58 UTC) #4
lpromero
lgtm
3 years, 8 months ago (2017-04-20 12:01:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834623002/1
3 years, 8 months ago (2017-04-20 12:01:52 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 13:25:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45d637552defb050205b9a1301b6...

Powered by Google App Engine
This is Rietveld 408576698