Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2834583004: Use generated copy and compare for VerticalAlign in ComputedStyle. (Closed)
Patch Set: vertical align Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 7a7cce01c33c544ddb773309dfcd49556b6227ff..7c4e644cc623f5a4e0cfb0eab6db8e0dfbc34ac9 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -338,7 +338,6 @@ void ComputedStyle::CopyNonInheritedFromCached(const ComputedStyle& other) {
// See comments for each skipped flag below.
// These are not generated in ComputedStyleBase
- SetVerticalAlign(other.VerticalAlign());
SetHasViewportUnits(other.HasViewportUnits());
SetHasRemUnitsInternal(other.HasRemUnits());
@@ -471,8 +470,6 @@ bool ComputedStyle::LoadingCustomFontsEqual(const ComputedStyle& other) const {
bool ComputedStyle::NonInheritedEqual(const ComputedStyle& other) const {
// compare everything except the pseudoStyle pointer
return ComputedStyleBase::NonInheritedEqual(other) &&
- VerticalAlign() == other.VerticalAlign() && // Not generated in
- // ComputedStyleBase
box_data_ == other.box_data_ &&
visual_data_ == other.visual_data_ &&
rare_non_inherited_data_ == other.rare_non_inherited_data_ &&
« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698