Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5

Issue 2834583004: Use generated copy and compare for VerticalAlign in ComputedStyle. (Closed)
Patch Set: vertical align Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 b/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
index 50961bfbd9b1e89437c9f4476eac0134c42a2515..68e408ab850c5e71eee2c9f48d15d5d91d259541 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
+++ b/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
@@ -153,15 +153,14 @@
has_custom_compare_and_copy: true,
},
// TODO(shend): vertical align is actually a CSS property, but since we don't support union fields
- // which can be either a keyword or Length, this is generated as a nonproperty for now. Remove this
- // once we can support union fields and groups.
+ // which can be either a keyword or Length, this is specified in this file for now. Remove this
+ // once we can support union fields.
{
name: "VerticalAlign",
field_template: "storage_only",
field_size: 4,
default_value: "EVerticalAlign::kBaseline",
type_name: "EVerticalAlign",
- has_custom_compare_and_copy: true,
},
{
name: "border",
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698